tests: simply & optimize spec drb usage #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't seem needed any longer, especially since 2.2.3: ruby/drb#35
Without this, you get nasty warnings like the below.
warning: thread "Ruby-0-Thread-1: /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1584" terminated with exception (report_on_exception is true):warning: thread "Ruby-0-Thread-38: /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1584" terminated with exception (report_on_exception is true):IOError: closed stream
select at org/jruby/RubyIO.java:3930
accept_or_shutdown at /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1015
accept at /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1001
main_loop at /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1765
run at /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1586
IOError: closed stream
select at org/jruby/RubyIO.java:3930
accept_or_shutdown at /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1015
accept at /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1001
main_loop at /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1765
run at /Users/chad/.local/share/mise/installs/ruby/jruby-9.4.14.0/lib/ruby/gems/shared/gems/drb-2.2.3/lib/drb/drb.rb:1586
… parent, not stdlib version Without this, tests break on JRuby 10 with errors such as `0x0000000000000fb4 is not id value` because `_idstr` is not used any longer. We want ruby/drb#35 to be available, requiring 2.2.3 on both client and server.
These are very short-lived processes, so optimisations aren't generally helpful. Shaves about 25% off bundler_spec.rb time (57s -> 46s) on a very quick machine.
chadlwilson
force-pushed
the
simplify-drb-usage
branch
from
d1ee958 to
aab3364
Compare
chadlwilson
changed the title
chadlwilson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--devon jruby