-
Notifications
You must be signed in to change notification settings - Fork 163
fomantic homepage #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fomantic homepage #891
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7810a40
Move index.html to index.liquid.
BigBlueHat 95ee0c3
Overhaul homepage to use Fomantic-UI.
BigBlueHat 75d96dd
Add Playground Next as a watch target.
BigBlueHat 4109657
Fix Playground Next width to match homepage.
BigBlueHat 68545ff
Use Markdownn for Primer index.
BigBlueHat 5a848b0
Use Markdown for Requirements index.
BigBlueHat e450bc8
Use Markdown for Specifications list.
BigBlueHat 2d7c8d9
Move default.liquid to bs2.liquid.
BigBlueHat 8162afa
Add IDs to homepage sections and footer.
BigBlueHat 5290e3c
Make cards on homepage stack on mobile.
BigBlueHat 6be40a2
Rework language card selections.
BigBlueHat b117339
Put large conditional section inside `liquid` tag.
BigBlueHat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <div class="card"> | ||
| <div class="content"> | ||
| <div class="header"><h3>{% if language %}{{ language | split: ',' | join: ' / ' }}{% else %}{{ applicationCategory }}{% endif %}</h3></div> | ||
| <div class="description"> | ||
| <div class="ui selection list"> | ||
| {% if language %} | ||
| {% assign languages = language | split: ',' %} | ||
| {% assign langExp = nil %} | ||
| {% for lang in languages %} | ||
| {% assign prefixed = lang | prepend: "imp.language contains '" | append: "'" %} | ||
| {% assign langExp = langExp | concat: prefixed %} | ||
| {% endfor %} | ||
| {% assign expression = langExp | join: ' or ' %} | ||
| {% assign imps = implementations | where_exp: 'imp', expression | where_exp: 'imp', 'imp.applicationCategory != "CLI"' %} | ||
| {% else %} | ||
| {% assign imps = implementations | where: 'applicationCategory', applicationCategory %} | ||
| {% endif %} | ||
| {% for implementation in imps %} | ||
| {% include 'implementation-item' %} | ||
| {% endfor %} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| <li typeof="schema:SoftwareSourceCode"> | ||
| <div class="item" typeof="schema:SoftwareSourceCode"> | ||
| <a property="schema:codeRepository" href="{{ implementation.repo }}"> | ||
| <span property="schema:name">{{ implementation.name }}</span> | ||
| <span class="badge{% unless implementation.state == 'InProgress' %}{% if implementation.jsonldVersion == 1.1 %} badge-success{% else %} badge-info{% endif %}{% endunless %}"> | ||
| <span class="ui label{% unless implementation.state == 'InProgress' %}{% if implementation.jsonldVersion == 1.1 %} green{% else %} blue{% endif %}{% endunless %}"> | ||
| {%- if implementation.jsonldVersion == 1.0 -%} | ||
| 1.0 | ||
| {%- else -%} | ||
| {{ implementation.jsonldVersion }}{% if implementation.state == 'InProgress' %} (<abbr title="Work In Progress">WIP</abbr>){% endif %} | ||
| {%- endif -%} | ||
| </span> | ||
| </a> | ||
| </li> | ||
| </div> |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something in here is being too aggressive and including JavaScript entries in the Java section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I missed that. Ah... it's the
containsbit. 😖 I'll see if I can improve that. Thanks!Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the issue...
containsis use for both array and string comparisons... 😖https://shopify.dev/docs/api/liquid/basics#selector(exact=You%20can%20use%20contains%20to%20check%20for%20the%20presence%20of%20a%20string%20within%20an%20array%2C%20or%20another%20string.,prefix=arraysAnchor%20to%20containscontains,suffix=%20You%20can%E2%80%99t%20use%20contains%20to%20check,type=TextQuoteSelector)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidlehn k. That was painful...but it's fixed now. See: 6be40a2