Draft
Conversation
just-be-dev
commented
Jul 8, 2025
| @@ -0,0 +1,3 @@ | |||
| module github.com/justbe-engineering/webview-client-go | |||
Owner
Author
There was a problem hiding this comment.
This module path is a hallucination. Need to fix that.
just-be-dev
commented
Jul 8, 2025
Comment on lines
+3
to
+15
| import ( | ||
| "bufio" | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "io" | ||
| "net/http" | ||
| "os" | ||
| "os/exec" | ||
| "path/filepath" | ||
| "runtime" | ||
| "sync" | ||
| ) |
Owner
Author
There was a problem hiding this comment.
Need to review these dependencies
just-be-dev
commented
Jul 8, 2025
Comment on lines
+17
to
+18
| // BinVersion should match the cargo package version | ||
| const BinVersion = "0.3.1" |
Owner
Author
There was a problem hiding this comment.
Should check to ensure the version updating script will also keep this version in sync
just-be-dev
commented
Jul 8, 2025
| ) | ||
|
|
||
| // Notification Messages that are sent unbidden from the webview to the client. | ||
| type Notification interface{} |
Owner
Author
There was a problem hiding this comment.
Is it possible to express this as a union type?
just-be-dev
commented
Jul 28, 2025
Comment on lines
+152
to
+156
| wn("// ContentProvider interface that all content types must implement"); | ||
| wn("type ContentProvider interface {"); | ||
| wn("\tisContent() // marker method"); | ||
| wn("}"); | ||
| wn(""); |
Owner
Author
There was a problem hiding this comment.
I don't actually like how mangled this is. Should just do a template string gen function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment in using Claude Code to implement new clients. This isn't ready to land yet, it needs a thorough review, but it looks very compelling so far!