-
Notifications
You must be signed in to change notification settings - Fork 34
Keystone: Endpoint controller #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
winiciusallan
wants to merge
9
commits into
k-orc:main
Choose a base branch
from
winiciusallan:endpoint-controller
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e367bc0
endpoint: generate code with scaffolding tool
winiciusallan 2783f0e
keystone: endpoint controller implementation
winiciusallan afefbc4
README: fix broken link to dev docs
mandre f79aa05
port: add adminStateUp field
winiciusallan ace2512
Get orc resources via their full names
mandre 03823af
port: add macaddress field
winiciusallan 95e605b
remove duplicated MACAddress and AdminStateUp status writing
winiciusallan 8712a02
bump: gophercloud to v2.10.0
winiciusallan 50f2218
change: drop name field, add description and enabled
winiciusallan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| Copyright 2025 The ORC Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| // EndpointResourceSpec contains the desired state of the resource. | ||
| type EndpointResourceSpec struct { | ||
| // description is a human-readable description for the resource. | ||
| // +kubebuilder:validation:MinLength:=1 | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
| Description *string `json:"description,omitempty"` | ||
|
|
||
| // enabled indicates whether the endpoint is enabled or not. | ||
| // +kubebuilder:default:=true | ||
| // +optional | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
|
|
||
| // interface indicates the visibility of the endpoint. | ||
| // +kubebuilder:validation:Enum:=admin;internal;public | ||
| // +required | ||
| Interface string `json:"interface,omitempty"` | ||
|
|
||
| // url is the endpoint URL. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +required | ||
| URL string `json:"url"` | ||
|
|
||
| // serviceRef is a reference to the ORC Service which this resource is associated with. | ||
| // +required | ||
| // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="serviceRef is immutable" | ||
| ServiceRef KubernetesNameRef `json:"serviceRef,omitempty"` | ||
| } | ||
|
|
||
| // EndpointFilter defines an existing resource by its properties | ||
| // +kubebuilder:validation:MinProperties:=1 | ||
| type EndpointFilter struct { | ||
| // interface of the existing endpoint. | ||
| // +kubebuilder:validation:Enum:=admin;internal;public | ||
| // +optional | ||
| Interface string `json:"interface,omitempty"` | ||
|
|
||
| // serviceRef is a reference to the ORC Service which this resource is associated with. | ||
| // +optional | ||
| ServiceRef *KubernetesNameRef `json:"serviceRef,omitempty"` | ||
|
|
||
| // url is the URL of the existing endpoint. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| URL string `json:"url,omitempty"` | ||
| } | ||
|
|
||
| // EndpointResourceStatus represents the observed state of the resource. | ||
| type EndpointResourceStatus struct { | ||
| // description is a human-readable description for the resource. | ||
| // +kubebuilder:validation:MinLength:=1 | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
| Description string `json:"description,omitempty"` | ||
|
|
||
| // enabled indicates whether the endpoint is enabled or not. | ||
| // +optional | ||
| Enabled bool `json:"enabled,omitempty"` | ||
|
|
||
| // interface indicates the visibility of the endpoint. | ||
| // +kubebuilder:validation:MaxLength=128 | ||
| // +optional | ||
| Interface string `json:"interface,omitempty"` | ||
|
|
||
| // url is the endpoint URL. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| URL string `json:"url,omitempty"` | ||
|
|
||
| // serviceID is the ID of the Service to which the resource is associated. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| ServiceID string `json:"serviceID,omitempty"` | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like the
Enabledfield shouldn't be there until your gophercloud PR adding support for it makes it to a gophercloud release we can use in ORC. I see you've droppedDescriptionthat has the same issue.Alternatively, we wait a bit for the next gophercloud release so that we have a clean PR from the start (we can include gophercloud/gophercloud#3581 in it too).