Add SchedulerHints to server controller #632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SchedulerHints to server controller NOTE! this change MOVED the ServerGroupRef inside the ServerSchedulerHints
Contributor
winiciusallan
left a comment
winiciusallan
left a comment
There was a problem hiding this comment.
Looks good overall! Great job! Just a few comments. Let me know what you think.
| // able to host the server. | ||
| // +kubebuilder:validation:MaxLength:=1024 | ||
| // +optional | ||
| Query *string `json:"query,omitempty"` |
Contributor
There was a problem hiding this comment.
I believe we don't need this pointer, since the zero-value isn't useful here. What do you think?
| // targetCell is a cell name where the server will be placed. | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
| TargetCell *string `json:"targetCell,omitempty"` |
Contributor
There was a problem hiding this comment.
Same for this pointer.
| // buildNearHostIP specifies a subnet of compute nodes to host the server. | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
| BuildNearHostIP *string `json:"buildNearHostIP,omitempty"` |
Comment on lines
+44
to
+45
| schedulerHints: | ||
| serverGroupRef: server-create-full |
Contributor
There was a problem hiding this comment.
I would add all the available fields for SchedulerHints that you've implemented on this test case, so we can test all working together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schedulerHints field with support for:
NOTE! this change MOVED the ServerGroupRef inside the ServerSchedulerHints