Port: change hostID to struct with id and serverRef fields #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Port API to use a structured hostID field instead of a simple string, allowing users to specify the host ID either directly or by referencing a Server resource.
Collaborator
Author
|
@winiciusallan I'd like your feedback on this. Related to my concerns in #626. |
Contributor
|
@mandre I have some questions just to clarify my thoughts and to ensure that we're on the same page. Could you point out a use case where I would retrieve the host ID from a running server? Making some tests on my multinode environment, if I do: create port A binded to host A -> create a server with port A into host B Openstack will change the binding:host_id to the host B on port A, because to a port become UP as long as I know, it must be attached on the same host as the VM. So, now I'm wondering if we really want to expose this field and if a use case for that exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Port API to use a structured hostID field instead of a simple string, allowing users to specify the host ID either directly or by referencing a Server resource.