add test cases for cloud/scope

Author: sp-yduck

cloud/scope/clients.go

@@ -38,7 +38,7 @@ func newComputeService(ctx context.Context, cluster *infrav1.ProxmoxCluster, crC
 	serverRef := cluster.Spec.ServerRef
 	secretRef := serverRef.SecretRef
 	if secretRef == nil {
-		return nil, errors.New("failed to get proxmox client form nil secretRef")
+		return nil, errors.New("failed to get proxmox client from nil secretRef")
 	}
 
 	var secret corev1.Secret

cloud/scope/clients_test.go

@@ -0,0 +1,68 @@
+package scope
+
+import (
+	"context"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+
+	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/errors"
+
+	infrav1 "github.com/sp-yduck/cluster-api-provider-proxmox/api/v1beta1"
+)
+
+var _ = Describe("newComputeService", func() {
+	var (
+		cluster *infrav1.ProxmoxCluster
+	)
+
+	Context("When SecretRef is not present in ProxmoxCluster", func() {
+		BeforeEach(func() {
+			cluster = &infrav1.ProxmoxCluster{}
+		})
+		It("should return proper error", func() {
+			svc, err := newComputeService(context.TODO(), cluster, k8sClient)
+			Expect(err.Error()).To(Equal("failed to get proxmox client from nil secretRef"))
+			Expect(svc).To(BeNil())
+		})
+	})
+
+	Context("When Secret is not present", func() {
+		BeforeEach(func() {
+			cluster = &infrav1.ProxmoxCluster{}
+			cluster.Spec.ServerRef.SecretRef = &infrav1.ObjectReference{
+				Namespace: "default",
+				Name:      "foo",
+			}
+		})
+
+		It("should return proper error", func() {
+			svc, err := newComputeService(context.TODO(), cluster, k8sClient)
+			Expect(errors.IsNotFound(err)).To(BeTrue())
+			Expect(svc).To(BeNil())
+		})
+	})
+
+	Context("When Secret is empty", func() {
+		BeforeEach(func() {
+			cluster = &infrav1.ProxmoxCluster{}
+			cluster.Spec.ServerRef.SecretRef = &infrav1.ObjectReference{
+				Namespace: "default",
+				Name:      "foo",
+			}
+			cluster.SetName("foo")
+			cluster.SetUID("bar")
+			secret := &corev1.Secret{}
+			secret.SetNamespace("default")
+			secret.SetName("foo")
+			k8sClient.Create(context.TODO(), secret)
+		})
+
+		It("Should return proper error", func() {
+			svc, err := newComputeService(context.TODO(), cluster, k8sClient)
+			Expect(err.Error()).To(Equal("invalid authentication config"))
+			Expect(svc).To(BeNil())
+		})
+	})
+})

cloud/scope/suite_test.go

@@ -0,0 +1,64 @@
+package scope
+
+import (
+	// "os"
+	"path/filepath"
+	"testing"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+
+	"k8s.io/client-go/kubernetes/scheme"
+	"k8s.io/client-go/rest"
+	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/envtest"
+	logf "sigs.k8s.io/controller-runtime/pkg/log"
+	"sigs.k8s.io/controller-runtime/pkg/log/zap"
+
+	infrav1 "github.com/sp-yduck/cluster-api-provider-proxmox/api/v1beta1"
+)
+
+var (
+	cfg             *rest.Config
+	k8sClient       client.Client
+	testEnv         *envtest.Environment
+	proxmoxUser     string
+	proxmoxPassword string
+)
+
+func TestScopes(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Scope Suite")
+}
+
+var _ = BeforeSuite(func() {
+	logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))
+
+	By("bootstrapping test environment")
+	testEnv = &envtest.Environment{
+		CRDDirectoryPaths:     []string{filepath.Join("..", "..", "config", "crd", "bases")},
+		ErrorIfCRDPathMissing: true,
+	}
+
+	var err error
+	// cfg is defined in this file globally.
+	cfg, err = testEnv.Start()
+	Expect(err).NotTo(HaveOccurred())
+	Expect(cfg).NotTo(BeNil())
+
+	Expect(clusterv1.AddToScheme(scheme.Scheme)).To(Succeed())
+	Expect(infrav1.AddToScheme(scheme.Scheme)).To(Succeed())
+
+	//+kubebuilder:scaffold:scheme
+
+	k8sClient, err = client.New(cfg, client.Options{Scheme: scheme.Scheme})
+	Expect(err).NotTo(HaveOccurred())
+	Expect(k8sClient).NotTo(BeNil())
+})
+
+var _ = AfterSuite(func() {
+	By("tearing down the test environment")
+	err := testEnv.Stop()
+	Expect(err).NotTo(HaveOccurred())
+})

go.mod

@@ -8,6 +8,7 @@ require (
 	github.com/onsi/gomega v1.27.10
 	github.com/pkg/errors v0.9.1
 	github.com/sp-yduck/proxmox-go v0.0.0-20230807140547-f03780ca1110
+	github.com/stretchr/testify v1.8.4
 	gopkg.in/yaml.v3 v3.0.1
 	k8s.io/api v0.26.1
 	k8s.io/apimachinery v0.26.1
@@ -48,6 +49,7 @@ require (
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
+	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/prometheus/client_golang v1.14.0 // indirect
 	github.com/prometheus/client_model v0.3.0 // indirect
 	github.com/prometheus/common v0.37.0 // indirect

go.sum

@@ -312,6 +312,7 @@ github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
 github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
 github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
 github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
+github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
 github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f/go.mod h1:N2zxlSyiKSe5eX1tZViRH5QA0qijqEDrYZiPEAiq3wU=
 github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415/go.mod h1:GwrjFmJcFw6At/Gs6z4yjiIwzuJ1/+UwLxMQDVQXShQ=
 github.com/xeipuuv/gojsonschema v1.2.0/go.mod h1:anYRn/JVcOK2ZgGU+IjEV4nwlhoK5sQluxsYJ78Id3Y=