-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
linux: add build requirement to Linux instructions #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a missing package needed for compiling the Linux version under Ubuntu.
📝 WalkthroughWalkthroughUpdates documentation for Linux prerequisites by adding qt6-tools-dev to build commands and introducing new prerequisite sections for OpenSSL, Libpulse, and CMake with accompanying code examples and minor formatting adjustments. Changes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
linux/README.md (1)
38-38: Fix typo: "EndevaourOS" should be "EndeavourOS".There are spelling inconsistencies for the distribution name. Lines 38 and 51 have "EndevaourOS" (missing 'v'), while lines 22 and 64 correctly spell it as "EndeavourOS".
- # On Arch Linux / EndevaourOS, these are included in the OpenSSL package, so you might already have them installed. + # On Arch Linux / EndeavourOS, these are included in the OpenSSL package, so you might already have them installed.Apply the same fix to line 51.
Also applies to: 51-51
🧹 Nitpick comments (1)
linux/README.md (1)
31-32: Fedora Qt6 section missing tools package equivalent.The Debian Qt6 build command now includes
qt6-tools-dev(line 28), but the Fedora Qt6 section (lines 31-32) does not include the equivalentqt6-qttools-develpackage. Consider adding it for consistency and to ensure all distros have the necessary build tools.# For Fedora sudo dnf install qt6-qtbase-devel qt6-qtconnectivity-devel \ - qt6-qtmultimedia-devel qt6-qtdeclarative-devel + qt6-qtmultimedia-devel qt6-qtdeclarative-devel qt6-qttools-devel
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
linux/README.md(4 hunks)
🔇 Additional comments (1)
linux/README.md (1)
35-46: Well-structured additions for build prerequisites.The new OpenSSL, Libpulse, and CMake prerequisite sections are well-organized, with consistent formatting across all three distributions (Arch/EndeavourOS, Debian/Ubuntu, and Fedora). These align correctly with the CMake-based build process shown in the Setup section (line 81). Package names are accurate and follow each distro's naming conventions.
Also applies to: 48-59, 61-72
|
I found the same issue and needed to obtain the referenced dependency. |
|
I just went to install on my main laptop, which uses Fedora 43 (which installed perfectly fine on 42 on my second laptop), and am getting this error: I'm trying to figure out what package is missing from the Fedora RPM. I thought Just thought I'd mention it. |
I did also ensure I followed each step of the build requirements: |
|
This will only work for the qt6 version of librepods. There is currently a rewrite using Rust + iced (#241) which will changes some of these requirements. |
There was a missing package needed for compiling the Linux version under Ubuntu.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.