-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add missing libs in debian linux build and add linux dektop entry #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdds a post-install step in Linux packaging to refresh icon caches and the desktop database, reformats install blocks in the CMake file, and expands Linux README with additional Debian build prerequisites and optional system-wide install/setup instructions. Changes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
linux/CMakeLists.txt (1)
83-122: Use optional cache-update tools to avoid installation failures on systems where they're unavailable.
update-icon-cachesis Debian/Ubuntu-specific and won't exist on Arch Linux or Fedora, causingmake installto fail on those systems. Since this project targets multiple distributions, these cache updates should be best-effort. Usefind_programto detect tool availability and skip gracefully if missing:install(CODE " message(STATUS \"Updating icon cache...\") - execute_process(COMMAND update-icon-caches ${CMAKE_INSTALL_DATAROOTDIR}/icons/hicolor) + find_program(GTK_UPDATE_ICON_CACHE gtk-update-icon-cache) + if(GTK_UPDATE_ICON_CACHE) + execute_process( + COMMAND \"${GTK_UPDATE_ICON_CACHE}\" -f -t \"${CMAKE_INSTALL_DATAROOTDIR}/icons/hicolor\" + RESULT_VARIABLE _icon_cache_rc + ) + else() + message(STATUS \"gtk-update-icon-cache not found; skipping.\") + endif() message(STATUS \"Updating desktop database...\") - execute_process(COMMAND update-desktop-database ${CMAKE_INSTALL_DATAROOTDIR}/applications) + find_program(UPDATE_DESKTOP_DB update-desktop-database) + if(UPDATE_DESKTOP_DB) + execute_process( + COMMAND \"${UPDATE_DESKTOP_DB}\" \"${CMAKE_INSTALL_DATAROOTDIR}/applications\" + RESULT_VARIABLE _desktop_db_rc + ) + else() + message(STATUS \"update-desktop-database not found; skipping.\") + endif() ")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
linux/CMakeLists.txt(2 hunks)linux/README.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
linux/README.md
90-90: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
94-94: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (1)
linux/README.md (1)
26-30: Debian prerequisites update matches the reported build failures (XKB + Qt6 LinguistTools).
Addinglibxkbcommon-devand the Qt6 tools/l10n packages is aligned with the missingXKB+Qt6LinguistToolserrors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
linux/README.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
linux/README.md
90-90: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (1)
linux/README.md (1)
26-29: Debian prerequisites additions address build failures.The expansion to include
qt6-base-dev-tools,qt6-tools-dev,qt6-tools-dev-tools,qt6-l10n-tools,libxkbcommon-dev, and standard build tools (build-essential,cmake,ninja-build) directly resolves the missing XKB and Qt6LinguistTools errors from the failed build logs. The changes align with the PR objectives.
|
Hi @kavishdevar , this is a great project, I recently used for my airbuds 4 ANC both on android + Linux - works pretty well and loved it. I have rasied this PR keeping in mind - naive users don't know how to make desktop entry and this could be a barrier in wider adoption of the project ! Also faced a build issue which this PR would fix. Thanks, |
Failed Build Logs:
View build error log