Fix macOS tray icon appearance on multi-monitor#359
Merged
kdroidFilter merged 1 commit intomasterfrom Feb 3, 2026
Merged
Conversation
Pre-render both light and dark icon variants at the Kotlin level and cache them in Swift so the appearance observer can swap icons instantly on screen/theme changes without a Kotlin round-trip. - Add tray_set_icons_for_appearance() native API (tray.h / tray.swift) - Cache light/dark NSImage in TrayContext, swap in observer evaluate() - Fix observer race condition: cancel settleItem on new appearance change - Reduce debounce from 40ms to 10ms for faster detection - Register context before starting KVO observation in tray_init - Add JNA binding and forwarding through MacTrayManager/MacTrayInitializer - Tray(ImageVector) with auto-tint pre-renders both variants on macOS Closes #306
kdroidFilter
force-pushed
the
fix/macos-tray-multimonitor-appearance
branch
from
ad70498 to
3abf6c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tray_set_icons_for_appearance()native APINSImageinstantly on appearance change — no Kotlin round-trip neededTest plan
Tray(ImageVector)on a multi-monitor macOS setup with different wallpapers/appearancesTray(Painter)andTray(DrawableResource)variants still benefit from the observer fix (faster detection)cd maclib && bash build.sh) and run./gradlew buildCloses #306