Fix tray icon not appearing on Windows 10#364
Merged
kdroidFilter merged 1 commit intomasterfrom Feb 3, 2026
Merged
Conversation
- Guard tray_enable_dark_mode() with SEH in native code to catch access violations from the undocumented uxtheme.dll ordinal 135 - Catch Throwable (not just Exception) in WindowsTrayManager tray thread - Move initLatch.countDown() into finally block so the calling thread is never deadlocked and can fall back to AWT gracefully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
winlibsubmodule:tray_enable_dark_mode()is now guarded with SEH to catch access violations from the undocumenteduxtheme.dllordinal 135 on some Windows 10 buildsThrowableinstead ofExceptionin the tray thread to handlejava.lang.Error: Invalid memory accessinitLatch.countDown()infinallyblock as a safety net so the calling thread is never deadlocked and can fall back to AWT gracefullyFixes #350