[AJDA-2024] Migrate from Azure Pipelines to GitHub Actions #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace Azure Pipelines with GitHub Actions workflow - Add GitHub Actions for docker-push and ACR authentication - Update ci-find-changes.sh to use GitHub Actions outputs - Remove deprecated snowpark and databricks images from docker-bake - Delete azure-pipelines.yml
- Add fetch-depth: 0 to checkout for git diff to work properly - Remove unreachable condition in build steps (changedProjects is never empty) - Remove docker-image-cache-restore step (images are built directly before push) - Simplify build commands to always use changedProjects output
- Python 3.8: Remove obsolete Python 2 packages (python-numpy, python-scipy, etc.) that are no longer available in Debian Bullseye
- Python 3.10: Add archive.debian.org redirects for EOL Debian Buster repositories
- Python 3.10: Remove pip3 check that fails due to intentional dependency version constraints
- Split workflow into detect-changes and build jobs - Use GitHub Actions matrix strategy to build Python 3.8 and 3.10 in parallel - Each version runs as independent job when changes are detected - Update publish-images job to reference correct outputs from detect-changes job This reduces CI build time when both Dockerfiles are modified.
ondrajodas
force-pushed
the
ondra/AJDA-2024
branch
from
7e89e4f to
2156344
Compare
- Export built Docker images to tar files - Upload images as GitHub Actions artifacts with 1 day retention - Update docker-image-cache-restore to download and load cached images - Remove redundant rebuild step from publish-images job - Images are now built once in parallel and reused in publish step
- Use docker buildx build with direct tar export instead of --load + docker save - This avoids loading image into Docker daemon, saving disk space - Reduces disk usage by ~50% as image is not stored twice
Remove incorrect 'to' argument that was causing docker load to fail
Change from 'ENV key value' to 'ENV key=value' format to remove Docker build warnings
…ython 3.10 - Pin mlflow<2.11 to ensure compatibility with cryptography<41 - Pin snowflake-connector-python<3.7 to ensure compatibility with cryptography<41 and pyopenssl==23.1.1 - Re-enable pip3 check to validate dependencies
Contributor
Author
|
ErikZigo
approved these changes
Jan 7, 2026
Contributor
ErikZigo
left a comment
ErikZigo
left a comment
There was a problem hiding this comment.
Only small notes. It looks fine to me.
I discussed this PR in detail with my AI colleague 🙂 After clarifying a few things, only this remained.
| description: Push Docker image to multiple registries | ||
| inputs: | ||
| imageCacheKey: | ||
| description: The image cache key (unused, kept for compatibility) |
Contributor
There was a problem hiding this comment.
Unused? it is used for artifacts name. So i think the description is wrong.
Comment on lines
-10
to
-18
| python-numpy \ | ||
| python-scipy \ | ||
| python-matplotlib \ | ||
| ipython \ | ||
| msodbcsql17 \ | ||
| mssql-tools \ | ||
| python-pandas \ | ||
| python-sympy \ | ||
| python-nose \ |
Contributor
There was a problem hiding this comment.
Python 2 packages. I do not why it was still here.
Co-authored-by: Erik Zigo <erik.zigo@keboola.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.