Skip to content

Conversation

@martinjunger
Copy link
Contributor

@martinjunger martinjunger commented Nov 23, 2021

Jira: KBC-2226

Before asking for review make sure that:

  • New client method(s) has tests
  • Apiary file is updated
  • You declared if there is a BC break or not (will affect next release of a client)

18:35:48-UTC - backend-mixed-redshift-atomic      -	There were 2 risky tests:
18:35:48-UTC - backend-mixed-redshift-atomic      -	
18:35:48-UTC - backend-mixed-redshift-atomic      -	1) Keboola\Test\Backend\Mixed\LegacyWorkspacesTest::testLoadUserError with data set #2 ('redshift', 'snowflake', array('VARCHAR', 'INTEGER'))
18:35:48-UTC - backend-mixed-redshift-atomic      -	This test did not perform any assertions
18:35:48-UTC - backend-mixed-redshift-atomic      -	
18:35:48-UTC - backend-mixed-redshift-atomic      -	/code/tests/Backend/Mixed/LegacyWorkspacesTest.php:310
18:35:48-UTC - backend-mixed-redshift-atomic      -	
18:35:48-UTC - backend-mixed-redshift-atomic      -	2) Keboola\Test\Backend\Mixed\LegacyWorkspacesTest::testLoadUserError with data set #6 ('redshift', 'snowflake', array(array('price', 'VARCHAR'), array('quantity', 'INTEGER')))
18:35:48-UTC - backend-mixed-redshift-atomic      -	This test did not perform any assertions
18:35:48-UTC - backend-mixed-redshift-atomic      -	
18:35:48-UTC - backend-mixed-redshift-atomic      -	/code/tests/Backend/Mixed/LegacyWorkspacesTest.php:310

zajca and others added 30 commits August 27, 2021 11:45
KBC-1783 testQueueCreate now sends name option
KBC-1783 fix testTableImportInvalidCsvParams api call parameters
Revert "fix expected columns names after webalize"
Revert "Tests: column names with underscores"
…nfig-row-copy

Revert "KBC-1723 copy devBranch configuration row"
KBC-34 testImportFromWorkspaceWithInvalidTableNames tests also tableCreate
…umeric-column-type

KBC-1825 fix data preview with numeric column type
jirkasemmler and others added 26 commits November 19, 2021 12:56
…ests-for-components

KBC-1726 consolidate DevBranch tests for components : part1
…sts-consolidation-part3

KBC-1726 DPM components tests consolidation part3
@martinjunger martinjunger force-pushed the KBC-2226-fix-test-testLoadUserError branch from bcc2e1d to 27bccc8 Compare November 23, 2021 14:34
@martinjunger martinjunger force-pushed the KBC-2226-fix-test-testLoadUserError branch from 27bccc8 to 2adfed3 Compare November 23, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants