-
-
Notifications
You must be signed in to change notification settings - Fork 270
Align announcement bar with theme colors for consistency and clear visibility(keploy/Docs #3002). #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
|
Hi sir @Achanandhi-M , I’ve submitted PR #683 fixing issue #3002. Could you please review it when you get time? I’m new to contributing and would love feedback. Thanks! |
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Gouravjaat07 please address the comments mentioned also please sign the DCO
| }, | ||
| "dependencies": { | ||
| "@docusaurus/core": "^3.2.1", | ||
| "@docusaurus/core": "^3.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Gouravjaat07 there is no need to update the docusaurus version
|
|
||
| /* 🔹 Keploy Docs Announcement Bar Custom Styling */ | ||
|
|
||
| /* Announcement Banner background + text */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need a announcement bar in the blue color, we are looking for a light orange background
What has changed?
Announcement Banner Styling
custom.cssto apply the correct background and text colors.Docusaurus Start Issue
'docusaurus' is not recognized as an internal or external commanderror.This PR Resolves #(3002)
Type of change
How Has This Been Tested?
npx docusaurus startand confirmed the dev server starts without errors.Before fixing issue :
After fixing issue :
Checklist:
Thanks for opening this pull request! If the tests fail, please feel free to reach out to us by leaving a comment down below and we will be happy to take a look