fix: Added validation logic to check if any required field is missing and improve error message #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or empty Signed-off-by: Saket Maurya <mauryapriyadarshi2004@gmail.com>
|
To generate Unit Tests for this PR, please click here. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds input validation for empty or missing fields across various book handlers and enhances related error messages, fixes a typo in the README, and introduces a default Keploy configuration file.
- Added checks for empty
book_idin GetBookByIDHandler and refined its error response - Introduced validation logic in AddBookHandler and UpdateBookHandler to catch missing/invalid fields
- Improved DeleteBookHandler with “not found or already deleted” handling
- Fixed a missing closing quote in the README command snippet
- Added keploy.yml with default settings
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/handlers/book_handler.go | Added validation logic and more descriptive error messages in handlers for get, add, delete, and update book operations |
| keploy.yml | Added default Keploy configuration file |
| README.md | Corrected missing closing quote in Keploy command example |
|
Hey @SaketV8, Thank you for raising the pr! Our team will review it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 The improvements I implemented:
This PR improves the error message returned when attempting to update a book that does not exist or hasn't been modified.
It enhances the error message shown when trying to delete a book that has already been deleted.
It also refines the error messages displayed when required fields are missing while adding a new book
It also improves the error message returned when getting book by ID by passing empty
bookID✨ fixed some readme typo too.