Skip to content

Conversation

@hertschuh
Copy link
Collaborator

The newshape argument to reshape is removed in NumPy 2.4.

The `newshape` argument to reshape is removed in NumPy 2.4.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility concern with the upcoming NumPy 2.4 release by modifying all instances of np.reshape to no longer use the newshape keyword argument. This change is a proactive measure to prevent breakage when the newshape argument is officially removed from NumPy, ensuring the codebase remains functional and up-to-date with its dependencies.

Highlights

  • NumPy Compatibility: Updated np.reshape calls to remove the newshape keyword argument, ensuring compatibility with the upcoming NumPy 2.4 release where this argument will be removed.
  • Code Modernization: Refactored np.reshape usage to align with modern NumPy API practices, making the code more robust against future library updates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the usage of np.reshape in a test file to be compatible with the upcoming NumPy 2.4 release by removing the deprecated newshape keyword argument. The change is straightforward, well-contained, and necessary for future compatibility. I find no issues with this modification.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.27%. Comparing base (7631c1a) to head (592558f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21899   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files         579      579           
  Lines       59917    59917           
  Branches     9403     9403           
=======================================
  Hits        45703    45703           
  Misses      11748    11748           
  Partials     2466     2466           
Flag Coverage Δ
keras 76.14% <ø> (ø)
keras-jax 62.70% <ø> (ø)
keras-numpy 57.36% <ø> (ø)
keras-openvino 34.29% <ø> (ø)
keras-torch 63.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull Ready to be merged into the codebase size:XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants