Skip to content

Conversation

@sjmiller609
Copy link
Collaborator

@sjmiller609 sjmiller609 commented Jan 27, 2026

I was having an issue with "hypeman push" when run from remote server, which I wanted to use for testing the gpu related changes.

Note

Strengthens image/repo name handling and registry auth.

  • Replace regex-based repo extraction with docker/distribution v2.Router() in oapi_auth.go to correctly parse /v2/{name}/... where name may contain slashes; update extractRepoFromPath accordingly
  • Add comprehensive tests: URL-decoding behavior of oapi-codegen runtime, Chi routing with URL-encoded slashes, and repo extraction across manifests/blobs/uploads paths; expand auth tests to reject registry-scoped tokens and edge cases
  • Update dependencies (docker/distribution, gorilla/mux, opencontainers/go-digest, google/uuid) to direct requirements

Written by Cursor Bugbot for commit 2fc0043. This will update automatically on new commits. Configure here.

@sjmiller609 sjmiller609 requested review from hiroTamada and rgarcia and removed request for hiroTamada January 27, 2026 14:51
Copy link
Contributor

@hiroTamada hiroTamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - using docker/distribution's router to parse registry paths is a solid approach that handles nested repo names correctly. good test coverage.

@sjmiller609 sjmiller609 merged commit 7ad40bc into main Jan 27, 2026
4 of 5 checks passed
@sjmiller609 sjmiller609 deleted the fix-image-parsing branch January 27, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants