Skip to content

Kafka lib version update#398

Merged
kjamrog merged 1 commit intomainfrom
kafka_lib_version_update
Feb 3, 2026
Merged

Kafka lib version update#398
kjamrog merged 1 commit intomainfrom
kafka_lib_version_update

Conversation

@kjamrog
Copy link
Collaborator

@kjamrog kjamrog commented Feb 3, 2026

Summary by CodeRabbit

  • Chores

    • Updated Kafka dependencies to version 1.24.0
  • Bug Fixes

    • Improved Kafka consumer event handling for group rebalancing operations

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Updates Kafka consumer event listener from 'consumer:rejoin' to 'consumer:group:rejoin', bumps the @platformatic/kafka dependency version from ^1.23.0 to ^1.24.0, and refactors test utilities to use adminClient.Admin type instead of Admin.

Changes

Cohort / File(s) Summary
Kafka Event Hook Update
packages/kafka/lib/AbstractKafkaConsumer.ts
Changed event listener from 'consumer:rejoin' to 'consumer:group:rejoin' with corresponding log message update to reflect group rebalance rejoining.
Dependency Upgrade
packages/kafka/package.json
Bumped @platformatic/kafka dependency version from ^1.23.0 to ^1.24.0.
Test Utility Refactoring
packages/kafka/test/utils/testContext.ts
Updated imports and type declarations to use adminClient.Admin instead of Admin; replaced instantiation accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

patch

Suggested reviewers

  • kibertoad

Poem

🐰 A consumer hops through Kafka streams so bright,
Rejoins its group with events done right,
Dependencies climb, test utils align,
Small changes like carrots in a line! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Kafka lib version update' is vague and generic, describing only that a version was bumped without specifying the scope or nature of the changes. Consider a more specific title that captures the main changes, such as 'Update Kafka consumer event listener and dependencies' or 'Update Kafka event hook and @platformatic/kafka version'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kafka_lib_version_update

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kjamrog kjamrog added patch and removed minor labels Feb 3, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/kafka/test/utils/testContext.ts (1)

9-67: ⚠️ Potential issue | 🔴 Critical

Fix incorrect import of Admin class from @platformatic/kafka.

Line 11 imports { adminClient } which does not exist. The correct import is:

import { Admin } from '@platformatic/kafka'

Update the type and instantiation to use Admin directly instead of adminClient.Admin.

@kjamrog kjamrog merged commit a0c8b08 into main Feb 3, 2026
41 checks passed
@kjamrog kjamrog deleted the kafka_lib_version_update branch February 3, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants