chore: revert stakeset handling in this subgraph and add new event parameter #1936

kemuru · 2025-03-27T22:25:18Z

add the new _amountAllCourts to the StakeSet events

also reverts #1901 as discussed since we don't want to handle this entity in this subgraph due to entity overload since StakeSet is very frequent

frontend unaffected

PR-Codex overview

This PR focuses on updating the StakeSet event handling in the Kleros V2 subgraph, including changes to the event structure, the addition of a new parameter, and updates to related functions and schemas.

Detailed summary

Bumped version in subgraph/package.json from 0.12.0 to 0.13.0.
Modified StakeSet type in schema.graphql to include an additional parameter.
Updated createStakeSetEvent function to accept a new parameter _amountAllCourts.
Adjusted the creation of newStakeSetEvent to include the new parameter.
Changed event handler signature from StakeSetEvent to StakeSet.
Removed the saving of StakeSetEntity in handleStakeSet function.
Updated event handlers in subgraph.yaml files to match the new StakeSet signature.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Refactor
- Streamlined the staking data model by removing the StakeSet entity from the SortitionModule.
- Updated event handling to accommodate a new parameter for the StakeSet event, enhancing data processing.
- Adjusted stake management to focus solely on updating user stakes without persisting extra data.
Chores
- Incremented the package version from 0.12.0 to 0.13.0 for consistency.

coderabbitai · 2025-03-27T22:25:27Z

Walkthrough

The pull request removes the StakeSet entity from multiple subgraph configuration files and from the GraphQL schema. Additionally, it updates the handleStakeSet function in both core and core-university modules by changing the method signature and removing the persistence logic for the StakeSetEntity. A call to ensureUser is now performed earlier in the function. Finally, the package version is updated from "0.12.0" to "0.13.0", while other aspects such as ABIs remain unchanged.

Changes

File(s)	Summary
`subgraph/core-neo/subgraph.yaml` `subgraph/core-university/subgraph.yaml` `subgraph/core/subgraph.yaml`	Removed the `StakeSet` entity from the `entities` list of the `SortitionModule` data source mapping. Updated the event signature for `StakeSet` to include an additional parameter.
`subgraph/core-university/src/SortitionModule.ts` `subgraph/core/src/SortitionModule.ts`	Updated the `handleStakeSet` function signature (removing the alias) and removed the creation/saving of a `StakeSetEntity`. Added an early call to `ensureUser`.
`subgraph/core/schema.graphql`	Removed the `StakeSet` type definition from the GraphQL schema.
`subgraph/package.json`	Updated package version from "0.12.0" to "0.13.0".
`subgraph/core/tests/sortition-module-utils.ts` `subgraph/core/tests/sortition-module.test.ts`	Updated the `createStakeSetEvent` function signature to accept an additional parameter, `_amountAllCourts`.

Suggested labels

Type: Feature🗿, Package: Web

Suggested reviewers

alcercu

Poem

I'm a rabbit, hopping through the code delight,
Changes made swiftly, under the moonlight.
StakeSet is gone, no more entity to chase,
Jurors are validated with a friendly embrace.
Version numbers rise, as the lines rearrange—
Hop on, code bunnies, our subgraph's in range!
🐰✨ Happy coding, day and night!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between c4b2cfe and 71bf6f4.

📒 Files selected for processing (1)

subgraph/package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

subgraph/package.json

⏰ Context from checks skipped due to timeout of 90000ms (15)

GitHub Check: Redirect rules - kleros-v2-university
GitHub Check: Header rules - kleros-v2-university
GitHub Check: Pages changed - kleros-v2-university
GitHub Check: Redirect rules - kleros-v2-testnet-devtools
GitHub Check: Header rules - kleros-v2-testnet-devtools
GitHub Check: Pages changed - kleros-v2-testnet-devtools
GitHub Check: Redirect rules - kleros-v2-testnet
GitHub Check: Redirect rules - kleros-v2-testnet
GitHub Check: Header rules - kleros-v2-testnet
GitHub Check: Header rules - kleros-v2-testnet
GitHub Check: Pages changed - kleros-v2-testnet
GitHub Check: Pages changed - kleros-v2-testnet
GitHub Check: contracts-testing
GitHub Check: Analyze (javascript)
GitHub Check: SonarCloud

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-03-27T22:25:34Z

👷 Deploy Preview for kleros-v2-testnet processing.

Name	Link
🔨 Latest commit	`e9263a1`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet/deploys/67e5d050740fb30008b1f990

netlify · 2025-03-27T22:25:34Z

👷 Deploy Preview for kleros-v2-testnet-devtools processing.

Name	Link
🔨 Latest commit	`e9263a1`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/67e5d050e86a0300088159b5

netlify · 2025-03-27T22:25:34Z

✅ Deploy Preview for kleros-v2-testnet ready!

Name	Link
🔨 Latest commit	`3397ab5`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet/deploys/67e68720d3c0e4000830a95f
😎 Deploy Preview	https://deploy-preview-1936--kleros-v2-testnet.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-03-27T22:25:35Z

✅ Deploy Preview for kleros-v2-testnet-devtools ready!

Name	Link
🔨 Latest commit	`3397ab5`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/67e687219ba58900075b9743
😎 Deploy Preview	https://deploy-preview-1936--kleros-v2-testnet-devtools.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-03-27T22:25:40Z

✅ Deploy Preview for kleros-v2-university ready!

Name	Link
🔨 Latest commit	`3397ab5`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-university/deploys/67e687202938af00082d04f2
😎 Deploy Preview	https://deploy-preview-1936--kleros-v2-university.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-03-27T22:25:50Z

✅ Deploy Preview for kleros-v2-neo ready!

Name	Link
🔨 Latest commit	`3397ab5`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-neo/deploys/67e68720d49e140008a581bd
😎 Deploy Preview	https://deploy-preview-1936--kleros-v2-neo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alcercu

lgtm

qlty-cloud-legacy · 2025-03-28T11:26:25Z

Code Climate has analyzed commit 3397ab5 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2
Style	1

View more on Code Climate.

sonarqubecloud · 2025-03-28T11:27:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chore: revert stakeset handling in this subgraph

e9263a1

kemuru requested a review from a team as a code owner March 27, 2025 22:25

kemuru requested a review from jaybuidl March 27, 2025 22:25

coderabbitai bot previously approved these changes Mar 27, 2025

View reviewed changes

kemuru marked this pull request as draft March 27, 2025 22:31

chore: more subgraph changes

c4b2cfe

kemuru dismissed coderabbitai[bot]’s stale review via c4b2cfe March 27, 2025 22:41

kemuru marked this pull request as ready for review March 27, 2025 22:41

kemuru changed the title ~~chore: revert stakeset handling in this subgraph~~ chore: revert stakeset handling in this subgraph and add new event parameter Mar 27, 2025

coderabbitai bot previously approved these changes Mar 27, 2025

View reviewed changes

chore: bump package json version

71bf6f4

kemuru dismissed coderabbitai[bot]’s stale review via 71bf6f4 March 27, 2025 22:47

coderabbitai bot approved these changes Mar 27, 2025

View reviewed changes

alcercu approved these changes Mar 28, 2025

View reviewed changes

Merge branch 'dev' into chore(subgraph)/amount-all-courts-calculations

3397ab5

jaybuidl changed the base branch from dev to feat/add-stakeset-total March 28, 2025 12:05

jaybuidl force-pushed the feat/add-stakeset-total branch from 4554947 to c399c03 Compare March 28, 2025 12:10

jaybuidl approved these changes Mar 28, 2025

View reviewed changes

jaybuidl merged commit ba85c09 into feat/add-stakeset-total Mar 28, 2025
23 of 26 checks passed

jaybuidl added Type: Enhancement ✨ Package: Subgraph Court subgraph labels Mar 28, 2025

jaybuidl deleted the chore(subgraph)/amount-all-courts-calculations branch May 19, 2025 12:15

This was referenced Aug 26, 2025

PNK penalties applied to the sortition tree stakes #2107

Merged

Sortition trees extracted to a library #2113

Merged

chore: revert stakeset handling in this subgraph and add new event parameter #1936

chore: revert stakeset handling in this subgraph and add new event parameter #1936

Uh oh!

Conversation

kemuru commented Mar 27, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

netlify bot commented Mar 27, 2025

👷 Deploy Preview for kleros-v2-testnet processing.

Uh oh!

netlify bot commented Mar 27, 2025

👷 Deploy Preview for kleros-v2-testnet-devtools processing.

Uh oh!

netlify bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kleros-v2-testnet ready!

Uh oh!

netlify bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kleros-v2-testnet-devtools ready!

Uh oh!

netlify bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kleros-v2-university ready!

Uh oh!

netlify bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kleros-v2-neo ready!

Uh oh!

alcercu left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot commented Mar 28, 2025

Uh oh!

sonarqubecloud bot commented Mar 28, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kemuru commented Mar 27, 2025 •

edited by pr-codex bot

Loading

coderabbitai bot commented Mar 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Mar 27, 2025 •

edited

Loading

netlify bot commented Mar 27, 2025 •

edited

Loading

netlify bot commented Mar 27, 2025 •

edited

Loading

netlify bot commented Mar 27, 2025 •

edited

Loading