Skip to content

fix: issue #537 Policies: use better markdown formatting #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaybuidl merged 1 commit into from
Jan 31, 2023
Merged

fix: issue #537 Policies: use better markdown formatting #550

jaybuidl merged 1 commit into from
Jan 31, 2023

Conversation

@Params10
Copy link
Contributor

@Params10 Params10 commented Jan 30, 2023

  • Updated the formatting of policy markdown.

  • Added code to solve new line issue(i.e \n was not parsed to
    ) in react-markdown library parser .

@netlify
Copy link

netlify bot commented Jan 30, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit bd2ce3b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/63d85fc74d96590009c4066b
😎 Deploy Preview https://deploy-preview-550--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jaybuidl jaybuidl linked an issue Jan 30, 2023 that may be closed by this pull request
Policies: use better markdown formatting #537
Closed
@jaybuidl jaybuidl added this to the alpha-1 milestone Jan 30, 2023
@jaybuidl jaybuidl requested review from alcercu and jaybuidl January 30, 2023 23:05
@jaybuidl
Copy link
Member

jaybuidl commented Jan 31, 2023

Looks good. I guess we just need something like this for the styling in light mode (not sure about dark mode):

ul {
    padding-inline-start: 1em;
    font-weight: 400;
    font-size: 16px;
    line-height: 24px;
    color: #333333;
}
Before After
image image

@jaybuidl jaybuidl force-pushed the fix/markdown-format branch from 796108c to bd2ce3b Compare January 31, 2023 00:24
@jaybuidl jaybuidl merged commit cffd71e into kleros:feat(web)/demo-staging Jan 31, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jaybuidl jaybuidl mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaybuidl jaybuidl jaybuidl approved these changes

@alcercu alcercu Awaiting requested review from alcercu

Assignees

No one assigned

Labels

Package: Web Court web frontend Type: Enhancement ✨

Projects

None yet

Milestone

testnet-1

Development

Successfully merging this pull request may close these issues.

Policies: use better markdown formatting

2 participants

@Params10 @jaybuidl