Skip to content

Comments

Fix: update minimum k8 version to fix timeouts, add versions to documentation and fix broken link.#602

Merged
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
twoGiants:issue-600-601-fix-typo-and-k8-version
Sep 9, 2025
Merged

Fix: update minimum k8 version to fix timeouts, add versions to documentation and fix broken link.#602
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
twoGiants:issue-600-601-fix-typo-and-k8-version

Conversation

@twoGiants
Copy link
Contributor

Changes

The default minimum k8 version for knative changed and is listed here: https://github.com/knative/pkg/blob/main/version/version.go#L36.

  • Update Kubernetes version to v1.32.0.
  • Update minimum minikube version to v1.35.
  • Add comment with link to default minimum kubernetes version needed by knative.
  • Fix broken link in docs.
  • Add versions of kubectl, kind and minikube to README.md.

/kind bug
/kind documentation

Fixes #601.
Fixes #600.

Release Note

Quickstart now uses Kubernetes version 1.32.0 as a default. 
The minimum recommended versions for Minikube is v1.35.
Documentation is updated to contain kubectl, kind and minikube versions.

@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. kind/documentation labels Sep 9, 2025
@knative-prow knative-prow bot requested review from dsimansk and psschwei September 9, 2025 16:45
@knative-prow
Copy link

knative-prow bot commented Sep 9, 2025

Welcome @twoGiants! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 9, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 9, 2025

Hi @twoGiants. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 9, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: twoGiants / name: Stanislav Jakuschevskij (64ece55)

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2025
The default minimum k8 version for knative changed and is listed here:
https://github.com/knative/pkg/blob/main/version/version.go#L36

Bump up k8, kind, and minikube versions and a comment with the link
above. Add versions to the main `README.md` and fix a broken link.

Issues knative-extensions#601 knative-extensions#600.

Signed-off-by: Stanislav Jakuschevskij <stas@two-giants.com>
@twoGiants twoGiants force-pushed the issue-600-601-fix-typo-and-k8-version branch from 309912e to 64ece55 Compare September 9, 2025 17:11
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2025
@psschwei
Copy link
Member

psschwei commented Sep 9, 2025

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2025
Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @twoGiants !!
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
@knative-prow knative-prow bot merged commit 32ac055 into knative-extensions:main Sep 9, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/documentation lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kn quickstart kind not working with newer versions of k8s Broken link in the documentation.

2 participants