Fix: update minimum k8 version to fix timeouts, add versions to documentation and fix broken link.#602
Conversation
|
Welcome @twoGiants! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉 |
|
Hi @twoGiants. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
The default minimum k8 version for knative changed and is listed here: https://github.com/knative/pkg/blob/main/version/version.go#L36 Bump up k8, kind, and minikube versions and a comment with the link above. Add versions to the main `README.md` and fix a broken link. Issues knative-extensions#601 knative-extensions#600. Signed-off-by: Stanislav Jakuschevskij <stas@two-giants.com>
309912e to
64ece55
Compare
|
/ok-to-test |
psschwei
left a comment
There was a problem hiding this comment.
Thanks for the PR @twoGiants !!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psschwei, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
The default minimum k8 version for knative changed and is listed here: https://github.com/knative/pkg/blob/main/version/version.go#L36.
README.md./kind bug
/kind documentation
Fixes #601.
Fixes #600.
Release Note