-
Notifications
You must be signed in to change notification settings - Fork 174
Fix link to CONTRIBUTING Guide in README #3326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @ishaanxgupta! It looks like this is your first PR to knative/func 🎉 |
|
Hi @ishaanxgupta. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@intojhanurag if there are any changes please let me know |
|
@matejvasek @dsimansk @jrangelramos awaiting your review on this one |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ishaanxgupta, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3326 +/- ##
==========================================
- Coverage 55.09% 55.05% -0.05%
==========================================
Files 170 170
Lines 19850 19850
==========================================
- Hits 10937 10928 -9
- Misses 7845 7853 +8
- Partials 1068 1069 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes
Changed the contribution link in the readme which fixed the broken link
/documentation
Fixes #3325