Skip to content

Fix gitlab test 3212 #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kunal1522 wants to merge 3 commits into from
Closed

Fix gitlab test 3212 #3329

Kunal1522 wants to merge 3 commits into from

Conversation

@Kunal1522
Copy link
Contributor

@Kunal1522 Kunal1522 commented Jan 5, 2026

FIxes #3212

@knative-prow
Copy link

knative-prow bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kunal1522
Once this PR has been reviewed and has the lgtm label, please assign lkingland for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 5, 2026

Hi @Kunal1522. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Jan 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.28%. Comparing base (3b43d86) to head (15d8424).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3329      +/-   ##
==========================================
- Coverage   55.03%   53.28%   -1.76%     
==========================================
  Files         170      170              
  Lines       19850    19850              
==========================================
- Hits        10925    10577     -348     
- Misses       7855     8258     +403     
+ Partials     1070     1015      -55
Flag Coverage Δ
e2e 39.59% <ø> (ø)
e2e go 35.62% <ø> (ø)
e2e node 31.13% <ø> (ø)
e2e python 35.27% <ø> (ø)
e2e quarkus 31.28% <ø> (ø)
e2e rust 30.74% <ø> (ø)
e2e springboot 30.75% <ø> (-0.03%) ⬇️
e2e typescript 31.25% <ø> (ø)
integration ?
unit macos-14 44.96% <ø> (ø)
unit macos-latest 44.96% <ø> (ø)
unit ubuntu-24.04-arm 45.07% <ø> (+<0.01%) ⬆️
unit ubuntu-latest 45.86% <ø> (ø)
unit windows-latest 44.98% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kunal1522 Kunal1522 marked this pull request as draft January 5, 2026 22:32
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2026
@Kunal1522 Kunal1522 force-pushed the fix-gitlab-test-3212 branch from 3345a09 to 7225443 Compare January 6, 2026 01:31
@Kunal1522 Kunal1522 marked this pull request as ready for review January 6, 2026 22:12
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2026
@Kunal1522
Re-enable TestInt_Gitlab in CI
82daff1 
Remove the CI skip condition that was added to temporarily disable
the GitLab integration test due to transient timeout issues.

Also fix the timeout error message to correctly state 10 minutes
(matching the actual timeout value) instead of 15 minutes.

Fixes: knative#3212
@Kunal1522
chore: retrigger CI
dc26b4a
@Kunal1522
Increase GitLab test timeout to 20 minutes for CI
15d8424 
CI builds are slower than local due to resource constraints.
Increasing from 10 to 20 minutes to accommodate slower buildpack builds.
@Kunal1522 Kunal1522 force-pushed the fix-gitlab-test-3212 branch from 2249b0f to 15d8424 Compare January 8, 2026 22:58
@Kunal1522 Kunal1522 mentioned this pull request Jan 12, 2026
Open
@matejvasek
Copy link
Contributor

matejvasek commented Jan 13, 2026

superseded by #3349

@matejvasek matejvasek closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

No one assigned

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reenable GitLab Integration test

2 participants

@Kunal1522 @matejvasek