-
Notifications
You must be signed in to change notification settings - Fork 174
docs: align JSDoc with signature and fix EOF newline #3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: align JSDoc with signature and fix EOF newline #3336
Conversation
Signed-off-by: DCchoudhury15 <divyanshuchoudhury3@gmail.com>
|
|
|
Welcome @DCchoudhury15! It looks like this is your first PR to knative/func 🎉 |
|
Hi @DCchoudhury15. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@intojhanurag up for review. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DCchoudhury15, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3336 +/- ##
==========================================
- Coverage 55.10% 55.03% -0.07%
==========================================
Files 170 170
Lines 19850 19850
==========================================
- Hits 10938 10925 -13
- Misses 7845 7855 +10
- Partials 1067 1070 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes
(context, body)function signature in the Node.js HTTP template to resolve confusion.@returnstag to the JSDoc to improve IDE autocomplete and documentation for function output.templates/node/http/index.jsto comply with project linting standards.generate/zz_filesystem_generated.goto ensure the template changes are included in thefuncbinary./kind cleanup
Fixes #3032
Release Note