Skip to content

Conversation

@DCchoudhury15
Copy link
Contributor

Changes

  • Aligned JSDoc parameters with the actual (context, body) function signature in the Node.js HTTP template to resolve confusion.
  • Added the missing @returns tag to the JSDoc to improve IDE autocomplete and documentation for function output.
  • Fixed a missing EOF (End Of File) newline in templates/node/http/index.js to comply with project linting standards.
  • Regenerated the embedded filesystem in generate/zz_filesystem_generated.go to ensure the template changes are included in the func binary.

/kind cleanup

Fixes #3032

Release Note

Fixed JSDoc and function signature mismatch in the Node.js HTTP template. The documentation now correctly reflects that 'body' is passed as a separate second argument.

Signed-off-by: DCchoudhury15 <divyanshuchoudhury3@gmail.com>
@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 8, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 8, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: DCchoudhury15 / name: Divyanshu Choudhury (6f7d6b6)

@knative-prow
Copy link

knative-prow bot commented Jan 8, 2026

Welcome @DCchoudhury15! It looks like this is your first PR to knative/func 🎉

@knative-prow
Copy link

knative-prow bot commented Jan 8, 2026

Hi @DCchoudhury15. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2026
@intojhanurag
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2026
@DCchoudhury15
Copy link
Contributor Author

@intojhanurag up for review.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DCchoudhury15, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.03%. Comparing base (392c49e) to head (6f7d6b6).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3336      +/-   ##
==========================================
- Coverage   55.10%   55.03%   -0.07%     
==========================================
  Files         170      170              
  Lines       19850    19850              
==========================================
- Hits        10938    10925      -13     
- Misses       7845     7855      +10     
- Partials     1067     1070       +3     
Flag Coverage Δ
e2e 39.59% <ø> (ø)
e2e go 35.62% <ø> (ø)
e2e node 31.13% <ø> (ø)
e2e python 35.25% <ø> (-0.10%) ⬇️
e2e quarkus 31.28% <ø> (ø)
e2e rust 30.72% <ø> (-0.01%) ⬇️
e2e springboot 30.77% <ø> (ø)
e2e typescript 31.25% <ø> (ø)
integration 17.51% <ø> (-0.03%) ⬇️
unit macos-14 44.96% <ø> (ø)
unit macos-latest 44.96% <ø> (ø)
unit ubuntu-24.04-arm 45.07% <ø> (ø)
unit ubuntu-latest 45.86% <ø> (ø)
unit windows-latest 44.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot merged commit 5a33e9e into knative:main Jan 13, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing JSDoc and function signature in http/index.js in the node template

3 participants