Skip to content

Add typed ErrInvalidRegistry error for registry validation #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Jan 13, 2026
Merged

Add typed ErrInvalidRegistry error for registry validation #3341

knative-prow merged 1 commit into from
Jan 13, 2026

Conversation

@Kunal1522
Copy link
Contributor

@Kunal1522 Kunal1522 commented Jan 11, 2026

FIxes #3339
Add ErrInvalidRegistry typed error and use errors.Is() check in testInvalidRegistry.

@Kunal1522
Add typed ErrInvalidRegistry error for registry validation
8b9ee29 
- Add ErrInvalidRegistry to pkg/functions/errors.go
- Wrap image name parsing error with ErrInvalidRegistry in function.go
- Update TestDeploy_InvalidRegistry to use errors.Is() for type checking

This ensures the test verifies the specific expected error rather than
passing on any unrelated error.

Resolves TODO comment in deploy_test.go.
@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 11, 2026

Hi @Kunal1522. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Jan 11, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.11%. Comparing base (6ccfe5f) to head (8b9ee29).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/functions/function.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3341      +/-   ##
==========================================
- Coverage   55.13%   55.11%   -0.02%     
==========================================
  Files         170      170              
  Lines       19965    19965              
==========================================
- Hits        11007    11004       -3     
- Misses       7881     7883       +2     
- Partials     1077     1078       +1
Flag Coverage Δ
e2e 39.39% <0.00%> (ø)
e2e go 35.44% <0.00%> (ø)
e2e node 30.99% <0.00%> (ø)
e2e python 35.09% <0.00%> (-0.02%) ⬇️
e2e quarkus 31.12% <0.00%> (-0.03%) ⬇️
e2e rust 30.53% <0.00%> (ø)
e2e springboot 30.63% <0.00%> (ø)
e2e typescript 31.10% <0.00%> (ø)
integration 17.45% <0.00%> (-0.01%) ⬇️
unit macos-14 45.10% <0.00%> (ø)
unit macos-latest 45.10% <0.00%> (ø)
unit ubuntu-24.04-arm 45.20% <0.00%> (ø)
unit ubuntu-latest 46.00% <0.00%> (ø)
unit windows-latest 45.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gauron99
gauron99 reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, Kunal1522

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
@knative-prow knative-prow bot merged commit cba1fdc into knative:main Jan 13, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gauron99 gauron99 gauron99 left review comments

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

@gauron99 gauron99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add typed ErrInvalidRegistry error

2 participants

@Kunal1522 @gauron99