Skip to content

Conversation

@gauron99
Copy link
Contributor

@knative-prow
Copy link

knative-prow bot commented Jan 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2026
@gauron99 gauron99 requested review from lkingland and matejvasek and removed request for dsimansk and jrangelramos January 14, 2026 12:27
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.37%. Comparing base (f508122) to head (6ffb3ae).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/buildpacks/builder.go 68.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3360      +/-   ##
==========================================
- Coverage   55.14%   53.37%   -1.78%     
==========================================
  Files         170      170              
  Lines       19970    19989      +19     
==========================================
- Hits        11013    10669     -344     
- Misses       7880     8293     +413     
+ Partials     1077     1027      -50     
Flag Coverage Δ
e2e 37.78% <0.00%> (-1.63%) ⬇️
e2e go ?
e2e node 30.95% <0.00%> (-0.04%) ⬇️
e2e python 35.05% <0.00%> (-0.04%) ⬇️
e2e quarkus 31.09% <0.00%> (-0.04%) ⬇️
e2e rust 30.54% <0.00%> (-0.03%) ⬇️
e2e springboot 30.59% <0.00%> (-0.04%) ⬇️
e2e typescript 31.06% <0.00%> (-0.04%) ⬇️
integration ?
unit macos-14 45.13% <73.33%> (+0.02%) ⬆️
unit macos-latest 45.13% <73.33%> (+0.02%) ⬆️
unit ubuntu-24.04-arm 45.22% <68.42%> (+0.02%) ⬆️
unit ubuntu-latest 46.03% <73.33%> (+0.02%) ⬆️
unit windows-latest 45.15% <73.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 marked this pull request as draft January 14, 2026 12:42
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2026
@gauron99
Copy link
Contributor Author

The problem here is that we need to identify "lowest supported version by bp"

@gauron99
Copy link
Contributor Author

I think I have a fix

@gauron99
Copy link
Contributor Author

fix now part of scaffolding #3237

@gauron99 gauron99 closed this Jan 14, 2026
@gauron99 gauron99 deleted the push-vtmsymzzvzzv branch January 16, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go] func build installs go twice?

1 participant