Skip to content

Bump k8s min version to 1.34 #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
creydr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump k8s min version to 1.34 #3317

creydr wants to merge 1 commit into from

Conversation

@creydr
Copy link
Member

@creydr creydr commented Feb 9, 2026

Next knative release (1.22) will require 1.34 as the min version (see Release-Schedule)

@creydr creydr requested a review from dprotaso February 9, 2026 16:17
@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from Cali0707 and skonto February 9, 2026 16:17
@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2026
@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.64%. Comparing base (57e664f) to head (c6666eb).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3317   +/-   ##
=======================================
  Coverage   74.64%   74.64%           
=======================================
  Files         188      188           
  Lines        8207     8207           
=======================================
  Hits         6126     6126           
  Misses       1841     1841           
  Partials      240      240

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.64%. Comparing base (57e664f) to head (c6666eb).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3317   +/-   ##
=======================================
  Coverage   74.64%   74.64%           
=======================================
  Files         188      188           
  Lines        8207     8207           
=======================================
  Hits         6126     6126           
  Misses       1841     1841           
  Partials      240      240

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dprotaso
dprotaso reviewed Feb 9, 2026
View reviewed changes
version/version_test.go
@@ -63,13 +63,13 @@ func TestVersionCheck(t *testing.T) {
actualVersion: &testVersioner{version: "v1.34.0"},
Copy link
Member

@dprotaso dprotaso Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be v1.35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso dprotaso left review comments

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@skonto skonto Awaiting requested review from skonto

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@creydr @dprotaso