Skip to content

fix: Strip parameter types from METHOD_CALL patterns #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shawn-hurley merged 1 commit into from
Nov 13, 2025
Merged

fix: Strip parameter types from METHOD_CALL patterns #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...r-bundle.core/src/main/java/io/konveyor/tackle/core/internal/symbol/CustomASTVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,20 @@ public enum QueryLocation {
}

public CustomASTVisitor(String query, SearchMatch match, QueryLocation location) {
/*
* Strip parameter types from the query pattern before matching
* The AST provides method names without parameter types, but users
* may specify patterns like "ClassName.method(ParamType1, ParamType2)"
* We need to remove the parameter types to match correctly
*/
String processedQuery = query.replaceAll("\\([^)]*\\)", "");

/*
* When comparing query pattern with an actual java element's fqn
* we need to make sure that * not preceded with a . are replaced
* by .* so that java regex works as expected on them
*/
this.query = query.replaceAll("(?<!\\.)\\*", ".*");
this.query = processedQuery.replaceAll("(?<!\\.)\\*", ".*");
this.symbolMatches = false;
this.match = match;
// depending on which location the query was for we only want to
Expand Down
Loading