👻 Attempting to fix buildah build

[shawn-hurley]

Summary by CodeRabbit

• Chores
  • Updated CI/CD workflow to enforce job execution order with task dependencies.
  • Modified Docker build process to adjust file permission handling during extraction.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Two configuration changes introduce workflow orchestration and Docker build adjustments: a job dependency is added to the image-build workflow requiring sequential execution, and tar extraction options are modified to exclude permission preservation during jdtls archive extraction.

Changes

Cohort / File(s)	Summary
CI/CD Workflow .github/workflows/image-build.yaml	Added needs: image-build dependency to build_image_analyzer job, ensuring sequential execution after the image-build job completes.
Docker Build Configuration Dockerfile	Modified tar extraction in jdtls-download stage to include --no-same-permissions flag alongside existing --no-same-owner, preventing permission preservation during archive extraction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The workflow now dances in proper sequence,
Dependencies binding each step with affection,
And in Docker's embrace, permissions take flight,
As tar builds our layers—perfectly tight! 🐇✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title uses vague phrasing ('Attempting to fix') and an emoji, making it unclear what specific buildah issue is being addressed or how the changes in job dependencies and tar extraction options resolve it.	Clarify the title to specifically describe the buildah build issue being fixed, such as 'Add job dependency and tar extraction options for buildah build' or 'Enforce image-build job dependency and fix file ownership in jdtls extraction'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 76df9a5 and 48710be.

📒 Files selected for processing (2)

• .github/workflows/image-build.yaml
• Dockerfile

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: JDT.LS Integration Tests (Phase 2)
• GitHub Check: Build tackle2-addon-analyzer

🔇 Additional comments (2)

.github/workflows/image-build.yaml (1)

31-31: LGTM! Proper job sequencing established.

Adding the needs: image-build dependency ensures the base image is built and pushed before triggering the java provider rebuild in the analyzer-lsp repository. This sequential execution prevents race conditions where the downstream rebuild might start before the updated image is available.

Dockerfile (1)

4-5: The permission concerns are largely unfounded in this specific context.

The jdtls archive contains only 3 executable files (jdtls, jdtls.bat, jdtls.py), and the actual impact of --no-same-permissions is minimal:

• The only executable used by the image is /jdtls/bin/jdtls, which is explicitly set to 755 on line 5
• jdtls.py from the archive is replaced by a local copy on line 8 anyway, making archive permissions irrelevant
• jdtls.bat is a Windows batch file, not applicable on Linux
• The remaining 114 files in the archive are data files (libraries, configuration, plugins) that should correctly have 644 permissions (-rw-r--r--)

The --no-same-permissions flag is appropriate here and doesn't introduce a real problem.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}