Skip to content

Fix NGINX #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbpolito merged 2 commits into from
Nov 13, 2025
Merged

Fix NGINX #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcf44d2
Fix NGINX
dbpolito Nov 13, 2025
0ec3c7d
Fix NGINX
dbpolito Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ jobs:
run: |
docker run localhost:5000/kooldev/php:${{ matrix.version }}${{ matrix.type }} php -r "extension_loaded('swoole') or die(1);"
docker run localhost:5000/kooldev/php:${{ matrix.version }}-nginx${{ matrix.type }} nginx -v
docker run localhost:5000/kooldev/php:${{ matrix.version }}-nginx${{ matrix.type }} nginx -t

- name: Tests (dev)
if: matrix.type == ''
Expand Down
3 changes: 1 addition & 2 deletions 8.1-swoole-nginx-prod/default.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ server {
add_header X-Frame-Options "SAMEORIGIN";

# basic H5BP suggestions
include h5bp/internet_explorer/x-ua-compatible.conf;
include h5bp/cross-origin/requests.conf;
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file h5bp/cross-origin/requests.conf does not exist in h5bp/server-configs-nginx version 5.0.1 (as specified in the Dockerfile). This will cause nginx configuration test failures.

In h5bp 5.0.1, the available files in the cross-origin directory are:

  • cross-origin/images.conf
  • cross-origin/web_fonts.conf
  • cross-origin/resource_timing.conf

Please verify which cross-origin configuration is needed for this use case, or remove this line if no cross-origin configuration is required.

Suggested change
include h5bp/cross-origin/requests.conf;

Copilot uses AI. Check for mistakes.
include h5bp/security/referrer-policy.conf;
include h5bp/security/x-content-type-options.conf;
include h5bp/security/x-xss-protection.conf;

# performance enhancements (mostly for caching static data)
include h5bp/web_performance/cache-file-descriptors.conf;
Expand Down
3 changes: 1 addition & 2 deletions 8.1-swoole-nginx/default.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ server {
add_header X-Frame-Options "SAMEORIGIN";

# basic H5BP suggestions
include h5bp/internet_explorer/x-ua-compatible.conf;
include h5bp/cross-origin/requests.conf;
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file h5bp/cross-origin/requests.conf does not exist in h5bp/server-configs-nginx version 5.0.1 (as specified in the Dockerfile). This will cause nginx configuration test failures.

In h5bp 5.0.1, the available files in the cross-origin directory are:

  • cross-origin/images.conf
  • cross-origin/web_fonts.conf
  • cross-origin/resource_timing.conf

Please verify which cross-origin configuration is needed for this use case, or remove this line if no cross-origin configuration is required.

Suggested change
include h5bp/cross-origin/requests.conf;

Copilot uses AI. Check for mistakes.
include h5bp/security/referrer-policy.conf;
include h5bp/security/x-content-type-options.conf;
include h5bp/security/x-xss-protection.conf;

# performance enhancements (mostly for caching static data)
include h5bp/web_performance/cache-file-descriptors.conf;
Expand Down
3 changes: 1 addition & 2 deletions 8.2-swoole-nginx-prod/default.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ server {
add_header X-Frame-Options "SAMEORIGIN";

# basic H5BP suggestions
include h5bp/internet_explorer/x-ua-compatible.conf;
include h5bp/cross-origin/requests.conf;
include h5bp/security/referrer-policy.conf;
include h5bp/security/x-content-type-options.conf;
include h5bp/security/x-xss-protection.conf;

# performance enhancements (mostly for caching static data)
include h5bp/web_performance/cache-file-descriptors.conf;
Expand Down
3 changes: 1 addition & 2 deletions 8.2-swoole-nginx/default.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ server {
add_header X-Frame-Options "SAMEORIGIN";

# basic H5BP suggestions
include h5bp/internet_explorer/x-ua-compatible.conf;
include h5bp/cross-origin/requests.conf;
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file h5bp/cross-origin/requests.conf does not exist in h5bp/server-configs-nginx version 5.0.1 (as specified in the Dockerfile). This will cause nginx configuration test failures.

In h5bp 5.0.1, the available files in the cross-origin directory are:

  • cross-origin/images.conf
  • cross-origin/web_fonts.conf
  • cross-origin/resource_timing.conf

Please verify which cross-origin configuration is needed for this use case, or remove this line if no cross-origin configuration is required.

Suggested change
include h5bp/cross-origin/requests.conf;

Copilot uses AI. Check for mistakes.
include h5bp/security/referrer-policy.conf;
include h5bp/security/x-content-type-options.conf;
include h5bp/security/x-xss-protection.conf;

# performance enhancements (mostly for caching static data)
include h5bp/web_performance/cache-file-descriptors.conf;
Expand Down
3 changes: 1 addition & 2 deletions 8.3-swoole-nginx-prod/default.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ server {
add_header X-Frame-Options "SAMEORIGIN";

# basic H5BP suggestions
include h5bp/internet_explorer/x-ua-compatible.conf;
include h5bp/cross-origin/requests.conf;
include h5bp/security/referrer-policy.conf;
include h5bp/security/x-content-type-options.conf;
include h5bp/security/x-xss-protection.conf;

# performance enhancements (mostly for caching static data)
include h5bp/web_performance/cache-file-descriptors.conf;
Expand Down
3 changes: 1 addition & 2 deletions 8.3-swoole-nginx/default.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ server {
add_header X-Frame-Options "SAMEORIGIN";

# basic H5BP suggestions
include h5bp/internet_explorer/x-ua-compatible.conf;
include h5bp/cross-origin/requests.conf;
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file h5bp/cross-origin/requests.conf does not exist in h5bp/server-configs-nginx version 5.0.1 (as specified in the Dockerfile). This will cause nginx configuration test failures.

In h5bp 5.0.1, the available files in the cross-origin directory are:

  • cross-origin/images.conf
  • cross-origin/web_fonts.conf
  • cross-origin/resource_timing.conf

Please verify which cross-origin configuration is needed for this use case, or remove this line if no cross-origin configuration is required.

Suggested change
include h5bp/cross-origin/requests.conf;

Copilot uses AI. Check for mistakes.
include h5bp/security/referrer-policy.conf;
include h5bp/security/x-content-type-options.conf;
include h5bp/security/x-xss-protection.conf;

# performance enhancements (mostly for caching static data)
include h5bp/web_performance/cache-file-descriptors.conf;
Expand Down
3 changes: 1 addition & 2 deletions 8.4-swoole-nginx-prod/default.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ server {
add_header X-Frame-Options "SAMEORIGIN";

# basic H5BP suggestions
include h5bp/internet_explorer/x-ua-compatible.conf;
include h5bp/cross-origin/requests.conf;
include h5bp/security/referrer-policy.conf;
include h5bp/security/x-content-type-options.conf;
include h5bp/security/x-xss-protection.conf;

# performance enhancements (mostly for caching static data)
include h5bp/web_performance/cache-file-descriptors.conf;
Expand Down
3 changes: 1 addition & 2 deletions 8.4-swoole-nginx/default.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ server {
add_header X-Frame-Options "SAMEORIGIN";

# basic H5BP suggestions
include h5bp/internet_explorer/x-ua-compatible.conf;
include h5bp/cross-origin/requests.conf;
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file h5bp/cross-origin/requests.conf does not exist in h5bp/server-configs-nginx version 5.0.1 (as specified in the Dockerfile). This will cause nginx configuration test failures.

In h5bp 5.0.1, the available files in the cross-origin directory are:

  • cross-origin/images.conf
  • cross-origin/web_fonts.conf
  • cross-origin/resource_timing.conf

Please verify which cross-origin configuration is needed for this use case, or remove this line if no cross-origin configuration is required.

Suggested change
include h5bp/cross-origin/requests.conf;

Copilot uses AI. Check for mistakes.
include h5bp/security/referrer-policy.conf;
include h5bp/security/x-content-type-options.conf;
include h5bp/security/x-xss-protection.conf;

# performance enhancements (mostly for caching static data)
include h5bp/web_performance/cache-file-descriptors.conf;
Expand Down
3 changes: 1 addition & 2 deletions template/default-tmpl.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@
add_header X-Frame-Options "SAMEORIGIN";

# basic H5BP suggestions
include h5bp/internet_explorer/x-ua-compatible.conf;
include h5bp/cross-origin/requests.conf;
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file h5bp/cross-origin/requests.conf does not exist in h5bp/server-configs-nginx version 5.0.1 (as specified in the Dockerfile). This will cause nginx configuration test failures.

In h5bp 5.0.1, the available files in the cross-origin directory are:

  • cross-origin/images.conf
  • cross-origin/web_fonts.conf
  • cross-origin/resource_timing.conf

Please verify which cross-origin configuration is needed for this use case, or remove this line if no cross-origin configuration is required.

Suggested change
include h5bp/cross-origin/requests.conf;

Copilot uses AI. Check for mistakes.
include h5bp/security/referrer-policy.conf;
include h5bp/security/x-content-type-options.conf;
include h5bp/security/x-xss-protection.conf;

# performance enhancements (mostly for caching static data)
include h5bp/web_performance/cache-file-descriptors.conf;
Expand Down