feat(metrics): add scheduler attempt counter #1931
Merged
+81
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/M
shmuelk
suggested changes
Dec 3, 2025
pkg/epp/metrics/metrics.go
Outdated
| // RecordSchedulingOutcome records metrics at the end of a scheduling attempt, | ||
| // including latency, attempt status. | ||
| func RecordSchedulingOutcome(duration time.Duration, err error) { | ||
| RecordSchedulerE2ELatency(duration) |
Contributor
There was a problem hiding this comment.
I don't think this metric should be nested in here. Please remove this call.
pkg/epp/scheduling/scheduler.go
Outdated
|
|
||
| defer func() { | ||
| metrics.RecordSchedulerE2ELatency(time.Since(scheduleStart)) | ||
| metrics.RecordSchedulingOutcome(time.Since(scheduleStart), err) |
Contributor
There was a problem hiding this comment.
Please replace this line and the deleted line above with:
Suggested change
| metrics.RecordSchedulingOutcome(time.Since(scheduleStart), err) | |
| duration := time.Since(scheduleStart) | |
| metrics.RecordSchedulerE2ELatency(duration) | |
| metrics.RecordSchedulingOutcome(duration, err) |
googs1025
force-pushed
the
metrics/scheduler_counter
branch
2 times, most recently
from
f54475a to
6983812
Compare
googs1025
changed the title
googs1025
force-pushed
the
metrics/scheduler_counter
branch
from
6983812 to
1f791b7
Compare
shmuelk
approved these changes
Dec 7, 2025
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
nirrozenbaum
reviewed
Dec 7, 2025
pkg/epp/scheduling/scheduler.go
Outdated
| before := time.Now() | ||
| result, err := s.profileHandler.ProcessResults(ctx, cycleState, request, profileRunResults) | ||
| metrics.RecordPluginProcessingLatency(framework.ProcessProfilesResultsExtensionPoint, s.profileHandler.TypedName().Type, s.profileHandler.TypedName().Name, time.Since(before)) | ||
| metrics.RecordSchedulerAttempt(err) |
Contributor
There was a problem hiding this comment.
This is not capturing correctly all error paths.
e.g., L82 is yet another path where the scheduler attempt fails.
Member
Author
There was a problem hiding this comment.
Thanks for this catch, I've made some change.
Signed-off-by: CYJiang <googs1025@gmail.com>
googs1025
force-pushed
the
metrics/scheduler_counter
branch
from
1f791b7 to
6b1988a
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: googs1025, nirrozenbaum, shmuelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Introduce
SchedulerAttemptsTotalcounter with "success"/"failure" statuslabels. This improves observability of
the scheduler for monitoring, alerting, and debugging in production.
Which issue(s) this PR fixes:
Fixes None
Does this PR introduce a user-facing change?: