Skip to content

Conversation

@Lucasgranet
Copy link
Contributor

@Lucasgranet Lucasgranet commented Aug 22, 2024

What this PR does / why we need it:
Adds the ability to add a Prometheus listener on the Octavia LoadBalancer in order to fetch it with any Prometheus scrapper to get metrics from the LoadBalancer.

This PR brings 4 new annotations:

loadbalancer.openstack.org/metrics-enable: "true" # Enable the listener endpoint on the Octavia LoadBalancer (default false)
loadbalancer.openstack.org/metrics-port: "9101" # Listener's port (default 9100)
loadbalancer.openstack.org/metrics-allow-cidrs: "10.0.0.0/8" # Listener's allowed cidrs (default none) - see below
loadbalancer.openstack.org/load-balancer-vip-address: "10.4.2.3" #  Auto-computed field based on Octavia VIP

Why you should have to use loadbalancer.openstack.org/metrics-allow-cidrs

It's strongly recommended to apply an allowed cidrs on the listener. If a Floating IP is attached to the Octavia, the metric endpoint will be exposed publicly. Apply a restriction to the K8S's subnet is recommended.

More detail on the Prometheus listener:
https://docs.openstack.org/octavia/latest/user/guides/monitoring.html#monitoring-with-prometheus

Which issue this PR fixes(if applicable):
fixes #2465

Special notes for reviewers:
A new E2E test has been added.

Release note:

[openstack-cloud-controller-manager] Support Octavia/Amphora Prometheus endpoint creation using annotations

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 22, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Lucasgranet. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2024
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch 6 times, most recently from ea89e68 to 1219946 Compare August 26, 2024 10:05
@Lucasgranet Lucasgranet marked this pull request as ready for review August 27, 2024 14:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch 4 times, most recently from fd375fb to 569454a Compare September 2, 2024 12:22
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2024
@jichenjc
Copy link
Contributor

jichenjc commented Sep 3, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2024
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from 569454a to feba13d Compare September 3, 2024 08:09
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2024
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from feba13d to 7fdbbc8 Compare September 3, 2024 10:27
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from b36aa05 to 55a87f2 Compare May 13, 2025 07:07
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from 55a87f2 to 605615e Compare May 26, 2025 11:31
@Lucasgranet
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2025
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from 605615e to 1ed6c8e Compare June 6, 2025 08:51
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2025
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from 1ed6c8e to 730536d Compare August 21, 2025 15:13
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch 3 times, most recently from 4a43ca2 to 864cdf3 Compare October 31, 2025 15:26
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from 864cdf3 to 5af871c Compare December 19, 2025 13:19
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2025
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from cb8fea9 to 9d5a36a Compare December 19, 2025 13:55
@Lucasgranet Lucasgranet marked this pull request as draft December 22, 2025 12:32
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2025
@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from 4035f51 to eff6c70 Compare January 19, 2026 09:57
@Lucasgranet
Copy link
Contributor Author

/retest

@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from eff6c70 to 4ebb4f6 Compare January 23, 2026 10:27
@Lucasgranet
Copy link
Contributor Author

/retest

@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from 4ebb4f6 to 6a62a42 Compare January 23, 2026 12:53
@Lucasgranet
Copy link
Contributor Author

/retest

@Lucasgranet
Copy link
Contributor Author

/retest-required

@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from 6a62a42 to 75abd28 Compare January 26, 2026 14:28
@Lucasgranet
Copy link
Contributor Author

/retest

@Lucasgranet Lucasgranet force-pushed the feat/occm/metric-annotations branch from 75abd28 to 07ca914 Compare January 26, 2026 14:49
@Lucasgranet
Copy link
Contributor Author

/retest

@Lucasgranet Lucasgranet marked this pull request as ready for review January 27, 2026 08:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[occm] Support Octavia/Amphora Prometheus endpoint creation using annotations

4 participants