-
Notifications
You must be signed in to change notification settings - Fork 654
[occm] Support Octavia/Amphora Prometheus endpoint creation using annotations #2633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[occm] Support Octavia/Amphora Prometheus endpoint creation using annotations #2633
Conversation
|
Hi @Lucasgranet. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ea89e68 to
1219946
Compare
fd375fb to
569454a
Compare
|
/ok-to-test |
569454a to
feba13d
Compare
feba13d to
7fdbbc8
Compare
b36aa05 to
55a87f2
Compare
55a87f2 to
605615e
Compare
|
/retest |
605615e to
1ed6c8e
Compare
1ed6c8e to
730536d
Compare
4a43ca2 to
864cdf3
Compare
864cdf3 to
5af871c
Compare
cb8fea9 to
9d5a36a
Compare
4035f51 to
eff6c70
Compare
|
/retest |
eff6c70 to
4ebb4f6
Compare
|
/retest |
4ebb4f6 to
6a62a42
Compare
|
/retest |
|
/retest-required |
6a62a42 to
75abd28
Compare
|
/retest |
75abd28 to
07ca914
Compare
|
/retest |
What this PR does / why we need it:
Adds the ability to add a Prometheus listener on the Octavia LoadBalancer in order to fetch it with any Prometheus scrapper to get metrics from the LoadBalancer.
This PR brings 4 new annotations:
Why you should have to use
loadbalancer.openstack.org/metrics-allow-cidrsIt's strongly recommended to apply an allowed cidrs on the listener. If a Floating IP is attached to the Octavia, the metric endpoint will be exposed publicly. Apply a restriction to the K8S's subnet is recommended.
More detail on the Prometheus listener:
https://docs.openstack.org/octavia/latest/user/guides/monitoring.html#monitoring-with-prometheus
Which issue this PR fixes(if applicable):
fixes #2465
Special notes for reviewers:
A new E2E test has been added.
Release note: