CI: Update Helm to v4.0.1. #14255
Open
CI: Update Helm to v4.0.1. #14255
+11
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
k8s-ci-robot
added
priority/backlog
There was a problem hiding this comment.
Pull request overview
This PR updates Helm from v3.19.2 to v4.0.1, which is a major version upgrade. The update is comprehensive but contains a critical issue with the Go import path that needs to be addressed before merging.
Key Changes:
- Updates Helm CLI version to v4.0.1 across all configuration files and workflows
- Updates the Go module dependency from
helm.sh/helm/v3tohelm.sh/helm/v4 - Changes the chartutil import path in Go code (requires verification)
- Updates transitive dependencies (mattn/go-isatty v0.0.19 → v0.0.20)
- Removes obsolete indirect dependencies (pkg/errors v0.9.1)
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| magefiles/steps/helm.go | Updates chartutil import to v4 path - critical issue identified with unusual nested version path |
| go.mod | Updates helm.sh/helm module from v3.19.2 to v4.0.1; removes indirect pkg/errors dependency |
| go.sum | Updates checksums for helm v4, mattn/go-isatty v0.0.20, and removes obsolete entries |
| hack/.tool-versions | Updates tool version reference from 3.19.2 to 4.0.1 |
| images/test-runner/Makefile | Updates HELM_VERSION build argument to 4.0.1 |
| charts/Makefile | Updates helm installation path from v3 to v4 |
| .github/workflows/ci.yaml | Updates azure/setup-helm version parameter to v4.0.1 |
| .github/workflows/chart.yaml | Updates azure/setup-helm version parameter to v4.0.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Gacko, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/triage accepted
/kind cleanup
/priority backlog
/cc @cpanato @strongjz @tao12345666333
/hold