Allow an action to get a copy of the logs raised during the action.#260
Merged
julianstirling merged 3 commits intomainfrom Feb 24, 2026
Merged
Allow an action to get a copy of the logs raised during the action.#260julianstirling merged 3 commits intomainfrom
julianstirling merged 3 commits intomainfrom
Conversation
julianstirling
commented
Feb 20, 2026
0644260 to
c584750
Compare
rwb27
approved these changes
Feb 23, 2026
Collaborator
rwb27
left a comment
There was a problem hiding this comment.
I'm happy to approve this with one change, which is the name of Thing.get_logs. I feel fairly strongly that the name of that function should make it very explicit that it's only logs related to the current invocation. That's a minor change, so I'll approve this so you don't need another round trip from me.
It might be nice to disentangle this from the server at some point - but that's too big a change to be in response to PR comments.
I have also flagged that the logs returned will be from all Things, so it would be nice in the future to move this out of Thing and into a module-level function.
Co-authored-by: Richard Bowman <richard.bowman@cantab.net>
597cfb0 to
4c91c61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For very long running tasks with lots of things happening (such as scanning on the OpenFlexure microscope) it is useful to be able to save a copy of the logs for a specific action along with the data created during the action.
This adds a function built into the
Thingclass to allow the action to retrieve its logs.