chore(media): azure support #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
Added Azure Blob Storage support in the media upload process, though there are concerns with header management across different storage providers.
- Added Azure-specific header
x-ms-blob-type: BlockBlobin/langfuse/_task_manager/media_manager.pyfor Azure Blob Storage compatibility - Potential issue with AWS header
x-amz-checksum-sha256being sent alongside Azure headers - Missing provider-specific header logic to handle different storage backends appropriately
- Risk of upload failures due to mixed cloud storage headers being sent simultaneously
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
201
to
+203
| "Content-Type": data["content_type"], | ||
| "x-amz-checksum-sha256": data["content_sha256_hash"], | ||
| "x-ms-blob-type": "BlockBlob", |
Contributor
There was a problem hiding this comment.
logic: AWS and Azure headers are mixed together. Should conditionally set headers based on the storage provider to avoid sending AWS headers to Azure and vice versa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds
x-ms-blob-type: BlockBlobheader inmedia_manager.pyfor Azure Blob Storage support.x-ms-blob-type: BlockBlobheader in_process_upload_media_job()inmedia_manager.pyto support Azure Blob Storage uploads.This description was created by
for ecf6edb. It will automatically update as commits are pushed.