Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Nov 25, 2024

Important

Add requests library to pyproject.toml dependencies with version ^2.

  • Dependencies:
    • Add requests library to pyproject.toml with version ^2.

This description was created by Ellipsis for 17745ed. It will automatically update as commits are pushed.

@hassiebp hassiebp merged commit 2eace54 into main Nov 25, 2024
4 of 9 checks passed
@hassiebp hassiebp deleted the add-requests-dep branch November 25, 2024 18:40
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

Added 'requests' library as a direct dependency alongside existing 'httpx' HTTP client in the Python package.

  • Added requests ^2 dependency in pyproject.toml which could lead to maintenance complexity with two HTTP clients
  • Version constraint ^2 is relatively loose, allowing any 2.x version updates
  • Potential for inconsistent HTTP client usage patterns across codebase with both httpx and requests
  • Consider documenting preferred HTTP client choice and usage guidelines

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants