Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Nov 27, 2024

Important

Fixes Langfuse server startup in CI by adjusting environment variables and ensuring a clean environment, with a minor test adjustment for data flushing.

  • CI Workflow:
    • In .github/workflows/ci.yml, added CLICKHOUSE_CLUSTER_ENABLED=false, LANGFUSE_READ_FROM_POSTGRES_ONLY=true, and LANGFUSE_READ_FROM_CLICKHOUSE_ONLY=false to the server startup command.
    • Removed .env file after database seeding to ensure a clean environment.
  • Tests:
    • Added langfuse.flush() in test_linking_via_id_observation_arg_legacy() in tests/test_datasets.py to ensure data is flushed.

This description was created by Ellipsis for 61b9316. It will automatically update as commits are pushed.

@hassiebp hassiebp enabled auto-merge (squash) November 27, 2024 10:21
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

Modifications to the CI workflow configuration to optimize Langfuse server startup by simplifying the database configuration to use PostgreSQL exclusively.

  • Removed .env file post database seeding to prevent environment variable conflicts
  • Added LANGFUSE_READ_FROM_POSTGRES_ONLY=true to enforce PostgreSQL as primary database
  • Disabled Clickhouse functionality via CLICKHOUSE_CLUSTER_ENABLED=false and LANGFUSE_READ_FROM_CLICKHOUSE_ONLY=false
  • Removed CLICKHOUSE_MIGRATION_URL environment variable to streamline configuration

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

(updates since last review)

Added test synchronization improvements to ensure proper event handling and data persistence during test execution.

  • Added langfuse.flush() call in test_linking_via_id_observation_arg_legacy to ensure events are persisted before assertions
  • Added health check step in CI workflow to verify Langfuse server readiness before running tests
  • Added retry logic with max attempts and logging for server health checks

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp disabled auto-merge November 27, 2024 12:47
@hassiebp hassiebp merged commit e5e3995 into main Nov 27, 2024
6 of 11 checks passed
@hassiebp hassiebp deleted the fix-ci branch November 27, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants