fix(media): add timeout to reference resolution

[hassiebp]

Important

Add timeout to resolve_media_references() in media.py and improve error handling in fetch_media() in client.py.

• Behavior:
  • Add content_fetch_timeout_seconds parameter to resolve_media_references() in media.py for media content fetching timeout.
  • Update fetch_media() in client.py to handle exceptions using handle_fern_exception().
• Classes:
  • Add FetchMediaResponse dataclass in client.py for fetch_media() method response.
• Logging:
  • Change logging from logging.warning to LangfuseMedia._log.warning in media.py for consistency.

^{This description was created by for d1ad3c8. It will automatically update as commits are pushed.}

[greptile-apps]

Disclaimer: Experimental PR review

PR Summary

This PR adds timeout functionality and improves media handling in the Langfuse Python client, focusing on better error handling and type safety.

• Added new FetchMediaResponse dataclass in /langfuse/client.py to properly type and structure media response data
• Implemented timeout parameter content_fetch_timeout_seconds in /langfuse/media.py to prevent hanging on slow media fetches
• Enhanced error handling in fetch_media method with proper try/catch blocks and logging
• Improved type hints and docstring documentation for media-related methods
• Switched to using class logger instead of root logger for better logging organization

_{2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

logic: timeout only applies to the GET request, but not to the fetch_media call which could also hang. Consider wrapping both operations in a timeout

[hassiebp]

todo: add link to main client

[greptile-apps]

Disclaimer: Experimental PR review

PR Summary

(updates since last review)

This PR continues to enhance the media handling functionality in the Langfuse Python client. Here's a concise summary of the latest changes:

• Added content_fetch_timeout_seconds parameter (default 10s) to resolve_media_references() in client.py to prevent indefinite hangs
• Moved media resolution functionality from LangfuseMedia class to Langfuse client for better organization
• Improved error handling in fetch_media() using handle_fern_exception() for consistent error management
• Updated test file to reflect the architectural changes in media resolution

The changes appear focused on improving reliability and maintainability of the media handling components.

_{2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}