Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Dec 22, 2024

Important

Change reset() in LangfuseSingleton to call shutdown() instead of flush() on _langfuse.

  • Behavior:
    • Change reset() method in LangfuseSingleton to call shutdown() instead of flush() on _langfuse instance.

This description was created by Ellipsis for 9801902. It will automatically update as commits are pushed.

@hassiebp hassiebp merged commit eefa3cb into main Dec 22, 2024
4 of 8 checks passed
@hassiebp hassiebp deleted the fix-singleton-reset branch December 22, 2024 10:00
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

Modified the LangfuseSingleton reset method to use shutdown() instead of flush(), ensuring more thorough resource cleanup including connection termination and thread shutdown.

  • Changed langfuse/utils/langfuse_singleton.py to call shutdown() instead of flush() in reset method for complete cleanup
  • Updated tests/test_singleton.py to verify proper shutdown behavior in reset functionality test
  • Potential breaking change for systems relying on flush-only behavior during reset operations

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants