Skip to content

fix(dataset+decorator): item observer with top-level generation #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 2 commits into from
Jan 2, 2025
Merged

fix(dataset+decorator): item observer with top-level generation #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0f2a54
fix(dataset+decorator): item observer with top-level generation
hassiebp Jan 2, 2025
07b0870
fix test
hassiebp Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion langfuse/decorators/langfuse_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,9 @@ def _prepare_call(
# Create wrapper trace if generation is top-level
# Do not add wrapper trace to stack, as it does not have a corresponding end that will pop it off again
trace = self.client_instance.trace(
id=id, name=name, start_time=start_time
id=_root_trace_id_context.get() or id,
name=name,
start_time=start_time,
)
self._set_root_trace_id(trace.id)

Expand Down
6 changes: 4 additions & 2 deletions tests/test_singleton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import pytest
import threading
from unittest.mock import patch

import pytest

from langfuse.utils.langfuse_singleton import LangfuseSingleton


Expand Down Expand Up @@ -64,4 +66,4 @@ def test_reset_functionality(mock_langfuse):

assert instance._langfuse is None

mock_langfuse.return_value.flush.assert_called_once()
mock_langfuse.return_value.shutdown.assert_called_once()
Loading