Skip to content

fix(model): update start_date type to datetime and make unit optional #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Julian-Schaefer wants to merge 1 commit into from
Closed

fix(model): update start_date type to datetime and make unit optional #1068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions langfuse/api/resources/commons/types/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ class Model(pydantic_v1.BaseModel):
Regex pattern which matches this model definition to generation.model. Useful in case of fine-tuned models. If you want to exact match, use `(?i)^modelname$`
"""

start_date: typing.Optional[dt.date] = pydantic_v1.Field(
start_date: typing.Optional[dt.datetime] = pydantic_v1.Field(
alias="startDate", default=None
)
"""
Apply only to generations which are newer than this ISO date.
"""

unit: ModelUsageUnit = pydantic_v1.Field()
unit: typing.Optional[ModelUsageUnit] = pydantic_v1.Field(default=None)
"""
Unit used by this model.
"""
Comment on lines +34 to 37
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Making unit optional may affect cost calculations if code assumes unit is always present. Ensure all consumers handle None case.

Expand Down