fix(api-models): usage unit to optional #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
Makes the unit field optional in the Model class, allowing model definitions without a specified usage unit in the Langfuse Python SDK.
- Modified
langfuse/api/resources/commons/types/model.pyto makeunitfield optional withtyping.Optional[ModelUsageUnit] - Potential breaking change for code that assumes
unitis always present - Aligns with CreateModelRequest where
unitwas already optional - Impacts model usage tracking and cost calculations where unit type is required
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+34
to
37
| unit: typing.Optional[ModelUsageUnit] = pydantic_v1.Field(default=None) | ||
| """ | ||
| Unit used by this model. | ||
| """ |
Contributor
There was a problem hiding this comment.
logic: Making unit optional could cause issues if any code relies on unit being present for cost calculations. Consider adding validation to ensure unit is present when input_price, output_price, or total_price are set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Make
unitfield optional inModelclass inmodel.py.model.py, changedunitfield inModelclass to be optional with a default ofNone.This description was created by
for 9ebeaf1. It will automatically update as commits are pushed.