Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Jan 28, 2025

Important

Increased sleep duration in test_llama_index_dataset() to fix flaky test and removed langchain-huggingface dependency.

  • Tests:
    • Increased sleep duration from 1 to 3 seconds in test_llama_index_dataset() in tests/test_datasets.py to address flaky test issues.
    • Added newline for readability in tests/test_datasets.py.
  • Dependencies:
    • Removed langchain-huggingface from pyproject.toml.

This description was created by Ellipsis for 8dcaac2. It will automatically update as commits are pushed.


Greptile Summary

Disclaimer: Experimental PR review

Increased sleep duration in test_llama_index_dataset to fix flaky test behavior caused by race conditions between API calls and assertions.

  • Modified tests/test_datasets.py to increase sleep time from 1 to 3 seconds to ensure asynchronous operations complete before assertions
  • Added newline for improved code readability in test file
  • Test validates Langfuse-LlamaIndex integration by verifying trace data after running queries

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp merged commit fe8fa12 into main Jan 28, 2025
10 checks passed
@hassiebp hassiebp deleted the hassieb/lfe-3745-fix-tests branch January 28, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants