Skip to content

fix(media): retry requests upload errors #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 4 commits into from
Feb 3, 2025
Merged

fix(media): retry requests upload errors #1100

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51b54b5
fix(media): retry requests upload errors
hassiebp Feb 3, 2025
5af273d
Update langfuse/_task_manager/media_manager.py
hassiebp Feb 3, 2025
aeb5e61
simplify
hassiebp Feb 3, 2025
3eb875b
Merge branch 'main' into fix-upload-retries
hassiebp Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions langfuse/_task_manager/media_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,22 +270,29 @@ def _process_upload_media_job(
def _request_with_backoff(
self, func: Callable[P, T], *args: P.args, **kwargs: P.kwargs
) -> T:
@backoff.on_exception(
backoff.expo, Exception, max_tries=self._max_retries, logger=None
)
def execute_task_with_backoff() -> T:
try:
return func(*args, **kwargs)
except ApiError as e:
if (
def _should_give_up(e: Exception) -> bool:
if isinstance(e, ApiError):
return (
e.status_code is not None
and 400 <= e.status_code < 500
and (e.status_code) != 429
):
raise e
except Exception as e:
raise e
and e.status_code != 429
)
if isinstance(e, requests.exceptions.RequestException):
return (
e.response is not None
and e.response.status_code < 500
and e.response.status_code != 429
)
return False

raise Exception("Failed to execute task")
@backoff.on_exception(
backoff.expo,
Exception,
max_tries=self._max_retries,
giveup=_should_give_up,
logger=None,
)
def execute_task_with_backoff() -> T:
return func(*args, **kwargs)

return execute_task_with_backoff()
Loading