Skip to content

fix(openai): handle usage object without mutation #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 3 commits into from
Feb 3, 2025
Merged

fix(openai): handle usage object without mutation #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f488123
fix(openai): handle usage object without mutation
hassiebp Feb 3, 2025
fb02aab
fix test
hassiebp Feb 3, 2025
979ce0b
fix test
hassiebp Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion langfuse/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ def _parse_usage(usage=None):
if usage is None:
return

usage_dict = usage.copy() if isinstance(usage, dict) else usage.__dict__
usage_dict = usage.copy() if isinstance(usage, dict) else usage.__dict__.copy()

for tokens_details in ["prompt_tokens_details", "completion_tokens_details"]:
if tokens_details in usage_dict and usage_dict[tokens_details] is not None:
Expand Down
8 changes: 4 additions & 4 deletions tests/test_openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_openai_chat_completion():
{"content": "1 + 1 = ", "role": "user"},
]
assert generation.data[0].type == "GENERATION"
assert generation.data[0].model == "gpt-3.5-turbo-0125"
assert "gpt-3.5-turbo-0125" in generation.data[0].model
assert generation.data[0].start_time is not None
assert generation.data[0].end_time is not None
assert generation.data[0].start_time < generation.data[0].end_time
Expand Down Expand Up @@ -135,7 +135,7 @@ def test_openai_chat_completion_stream():

assert generation.data[0].input == [{"content": "1 + 1 = ", "role": "user"}]
assert generation.data[0].type == "GENERATION"
assert generation.data[0].model == "gpt-3.5-turbo-0125"
assert "gpt-3.5-turbo-0125" in generation.data[0].model
assert generation.data[0].start_time is not None
assert generation.data[0].end_time is not None
assert generation.data[0].start_time < generation.data[0].end_time
Expand Down Expand Up @@ -536,7 +536,7 @@ def test_openai_completion():
assert completion.choices[0].text == generation.data[0].output
assert generation.data[0].input == "1 + 1 = "
assert generation.data[0].type == "GENERATION"
assert generation.data[0].model == "gpt-3.5-turbo-instruct"
assert "gpt-3.5-turbo-instruct" in generation.data[0].model
assert generation.data[0].start_time is not None
assert generation.data[0].end_time is not None
assert generation.data[0].start_time < generation.data[0].end_time
Expand Down Expand Up @@ -587,7 +587,7 @@ def test_openai_completion_stream():

assert generation.data[0].input == "1 + 1 = "
assert generation.data[0].type == "GENERATION"
assert generation.data[0].model == "gpt-3.5-turbo-instruct"
assert "gpt-3.5-turbo-instruct" in generation.data[0].model
assert generation.data[0].start_time is not None
assert generation.data[0].end_time is not None
assert generation.data[0].start_time < generation.data[0].end_time
Expand Down