fix(serializer): NaN handling #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| if np is not None and isinstance(obj, np.generic): | ||
| return obj.item() | ||
|
|
||
| if isinstance(obj, float) and math.isnan(obj): |
Contributor
There was a problem hiding this comment.
Consider also handling Infinity (math.isinf) alongside NaN if consistent nulling of non-finite floats is desired.
Suggested change
| if isinstance(obj, float) and math.isnan(obj): | |
| if isinstance(obj, float) and (math.isnan(obj) or math.isinf(obj)): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Handle NaN values in
EventSerializer.defaultby returningNone.EventSerializer.default, handlefloatNaN values by returningNone.This description was created by
for 85bc086. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Adds handling for NaN (Not a Number) float values in the EventSerializer class by converting them to None during JSON serialization, since NaN values are not valid in JSON.
langfuse/serializer.pyby converting NaN floats to None