Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Feb 25, 2025

Important

Add langfuse_mask configuration to OpenAILangfuse.initialize() in openai.py.

  • Behavior:
    • Add mask=openai.langfuse_mask to OpenAILangfuse.initialize() in openai.py to support langfuse_mask configuration.
  • Misc:
    • Minor formatting change in get_openai_args() in openai.py.

This description was created by Ellipsis for 5248943. It will automatically update as commits are pushed.

Greptile Summary

Disclaimer: Experimental PR review

Added support for the langfuse_mask parameter in the OpenAI integration, allowing sensitive data masking when using the Langfuse drop-in replacement for OpenAI.

  • Added mask=openai.langfuse_mask parameter to LangfuseSingleton().get() in langfuse/openai.py to properly pass masking configuration
  • Improved code formatting in get_openai_args() method for better readability
  • Ensures consistent masking behavior between direct Langfuse SDK usage and the OpenAI integration
  • Maintains backward compatibility with existing code using the OpenAI integration

@hassiebp hassiebp linked an issue Feb 25, 2025 that may be closed by this pull request
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp merged commit 69a6a0a into main Feb 26, 2025
8 of 10 checks passed
@hassiebp hassiebp deleted the hassieb/lfe-3975-fix-openai-mask branch February 26, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Unable to mask using OpenAI SDK Integration

2 participants