Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Mar 13, 2025

Important

Reorder function calls in IngestionConsumer to apply masking before multimodal handling in ingestion_consumer.py.

  • Behavior:
    • Reorder function calls in _next() method of IngestionConsumer class in ingestion_consumer.py.
    • Call _apply_mask_in_place(event) before _media_manager.process_media_in_event(event) to ensure masking occurs before multimodal handling.

This description was created by Ellipsis for bf9d33a. It will automatically update as commits are pushed.

Greptile Summary

Disclaimer: Experimental PR review

Moved masking operation before multimodal data handling in the ingestion consumer to ensure sensitive data is properly masked prior to any media processing or storage.

  • Modified _next method in /langfuse/_task_manager/ingestion_consumer.py to perform masking before multimodal handling
  • Ensures sensitive data is protected before being potentially stored in media files
  • Maintains proper error handling and logging for mask function failures

@hassiebp hassiebp linked an issue Mar 13, 2025 that may be closed by this pull request
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp enabled auto-merge (squash) March 13, 2025 10:06
@hassiebp hassiebp merged commit 4b22e8c into main Mar 13, 2025
10 checks passed
@hassiebp hassiebp deleted the hassieb/lfe-4129-mask-before-multimodal branch March 13, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply event masking prior to multimodal handling

2 participants