Skip to content

Conversation

@marcklingen
Copy link
Member

@marcklingen marcklingen commented Apr 17, 2025

Important

Adds environment filtering to fetch_traces() and fetch_observations() in client.py, maintaining backward compatibility.

  • Behavior:
    • Added environment parameter to fetch_traces() and fetch_observations() in client.py for filtering by environment.
    • Maintains backward compatibility with existing method signatures.
  • Logging:
    • Updated debug logs in fetch_traces() and fetch_observations() to include environment parameter.

This description was created by Ellipsis for a43e858. It will automatically update as commits are pushed.


Greptile Summary

Disclaimer: Experimental PR review

Added environment filtering capabilities to the fetch_traces() and fetch_observations() methods in the Langfuse Python client, enabling filtering of traces and observations by environment.

  • Added optional environment parameter to fetch_traces() and fetch_observations() methods in /langfuse/client.py
  • Environment parameter allows filtering traces and observations based on specified environments
  • Implementation includes proper type hints and validation for environment filtering
  • Maintains backward compatibility with existing method signatures

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@marcklingen marcklingen enabled auto-merge (squash) April 17, 2025 09:32
@marcklingen marcklingen merged commit 7cf71fc into main Apr 17, 2025
10 checks passed
@marcklingen marcklingen deleted the marc/lfe-4830 branch April 17, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants