fix(langchain): deployment version in model name #1204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes Azure OpenAI model name extraction in
_extract_model_name()to prevent duplicate version info inutils.py._extract_model_name()inutils.pyto correctly assigndeployment_versionanddeployment_name.deployment_versionindeployment_name.deployment_versionis only appended if not already indeployment_name.Noneifdeployment_nameis not a string.This description was created by
for 15e510e. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixes model name extraction logic for Azure OpenAI models in the Langfuse Python SDK to prevent duplicate version information in model names.
_extract_model_name()wheredeployment_versionwas being assigned todeployment_namedeployment_namecould be overwritten bydeployment_versiondue to variable reuse